Warning on overwriting existing theme

Bug #904928 reported by Meinert Jordan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Released
Low
Phill

Bug Description

Currently OpenLP silently overwrites existing themes with imported themes of the same name.
In some cases it might even overwrite themes with a different name as some characters are striped away from openlp.org 1.x theme names (the theme named "C Note" will overwritten by a theme named "C++ Note").

I'd like to see some [skip] [overwrite] [overwrite all] dialog.

While overwriting a existing theme legacy files from the old one should be removed.

Related branches

Meinert Jordan (m2j)
Changed in openlp:
milestone: none → 1.9.9
importance: Undecided → Low
Revision history for this message
Phill (phill-ridout) wrote :

How about just happening a number on the end if it already exists?

Phill (phill-ridout)
Changed in openlp:
assignee: nobody → phill (phill-ridout)
Changed in openlp:
status: New → Confirmed
Revision history for this message
Meinert Jordan (m2j) wrote :

I like more to see a warning, as this makes it easier to update the themes. With numbers, you have to remove the theme from all items, delete it, and import a changed one. Adding a number might be a option in the warning dialog.

Changed in openlp:
status: Confirmed → Fix Committed
Changed in openlp:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.