Warning on overwriting existing theme
Bug #904928 reported by
Meinert Jordan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Released
|
Low
|
Phill |
Bug Description
Currently OpenLP silently overwrites existing themes with imported themes of the same name.
In some cases it might even overwrite themes with a different name as some characters are striped away from openlp.org 1.x theme names (the theme named "C Note" will overwritten by a theme named "C++ Note").
I'd like to see some [skip] [overwrite] [overwrite all] dialog.
While overwriting a existing theme legacy files from the old one should be removed.
Related branches
lp:~phill-ridout/openlp/overwrite
- Tim Bentley: Approve
- Jonathan Corwin (community): Approve
- Raoul Snyman: Pending requested
-
Diff: 692 lines (+204/-182)1 file modifiedopenlp/core/ui/thememanager.py (+204/-182)
Changed in openlp: | |
milestone: | none → 1.9.9 |
importance: | Undecided → Low |
Changed in openlp: | |
assignee: | nobody → phill (phill-ridout) |
Changed in openlp: | |
status: | New → Confirmed |
Changed in openlp: | |
status: | Confirmed → Fix Committed |
Changed in openlp: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
How about just happening a number on the end if it already exists?