Trunk : Total Injustice to the company 'name' !

Bug #904408 reported by Serpent Consulting Services
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Server (MOVED TO GITHUB)
Fix Released
Low
OpenERP's Framework R&D

Bug Description

Guys,

I am not sure how critical this would be, but we faced this live on an implementation and was really a shocker.

There seems to be 2 issues, both the issues have same root!

Case 1. Try to duplicate the company record, although this should never go as a real case I guess. System would give you an error of not null constrain for the field 'name'. The field name is a fields.related and can usually fail in this case.

Proposed solution : copy() should be overridden and it can manage the rest.

Case 2. Keeping the field as related is fine, but injustice happens when the same name(from Partner model,feeling like a rich) when goes to name of the company, feels like filthy. In technical terms, the size of the name for partner_id appears to be 128 chars and name for company stands as 64 chars long. This results in "DataError: value too long for type character varying(64)" when the name of the partner doesn't really fit company name.

Proposed Solution : size for name field of company should be reset to 128.

Attached merges would pave the way for the solution.

Hope this helps.

Thanks,
Serpent Consulting Services.

Related branches

summary: - Trunk : Total Injustice to the company name
+ Trunk : Total Injustice to the company 'name' !
Revision history for this message
Serpent Consulting Services (serpent-consulting-services) wrote :

To update, applying this proposal, would solve both the issues!

Revision history for this message
Amit Parik (amit-parik) wrote :

Hello,

I am confirming this issue for case#1 which is related to Integrity Error.

For case#2, I am not sure about the increasing the Size of the name related filed on res.comapny object because in res.partner object I have seen the same size, So I think it don't creates any problem.

@Framework Team:
You can take appropriate decision on case#2.

@Sepent Consulting Service:
I didn't agree with your comment#1 that your fixes fixed the both problem.
Correct me If I am wrong!.

Thank you!

Changed in openobject-server:
assignee: nobody → OpenERP's Framework R&D (openerp-dev-framework)
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Vo Minh Thu (thu) wrote :

Thanks for the bug report, case #2 is fixed in trunk:
revno: 3937
revision-id: <email address hidden>

Changed in openobject-server:
status: Confirmed → Fix Released
Revision history for this message
Serpent Consulting Services (serpent-consulting-services) wrote :

Vo Minh Thu,

Thank you for the merge.

Changed in openobject-server:
milestone: none → 6.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.