Problems when ctrl_c_item is None (patch attached)

[Garrison Hoffman]

The version of Glipper shipped in precise (2.3-1) contains a serious bug (LP: #904367) which causes glipper to crash repeatedly, often at startup. A simple fix was applied to the 2.4 branch and backported to the 2.3-3 package in Debian. Can a SRU be started so that we can get glipper 2.3-3 into Precise? This is not necessary for Quantal which ships with 2.4-1 and already includes the patch.

[Impact]

 * Glipper often crashes the first time the clipboard changes after launch with an error:

  Traceback (most recent call last):
    File "/home/garrison/Code/github/glipper.bzr/glipper/AppIndicator.py", line 144, in on_history_changed
      self.update_menu(history_list)
    File "/home/garrison/Code/github/glipper.bzr/glipper/AppIndicator.py", line 79, in update_menu
      menu_item = gtk.CheckMenuItem(format_item(item), False)
    File "/home/garrison/Code/github/glipper.bzr/glipper/AppIndicator.py", line 185, in format_item
      i = item.replace("\n", " ")
  AttributeError: 'NoneType' object has no attribute 'replace'

[Test Case]

* Launch Glipper in an X session with no clipboard history (e.g., in a new `vncserver`) and copy some text to the clipboard. Glipper should not crash.

[Regression Potential]

* Very low. The modified bit of code is very small and well-tested at this point (since it has been in wheezy for several months).

[Laszlo Pandy (laszlok)]

You are right. Good patch. I will include it in the next release in January.

[René (pirateking)]

Precise Pangolin has still version 2.3 - so all users of new release are affected by this bug. Would it be possible to push version 2.4 to the repositories?

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "history.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[José Ernesto Dávila Pantoja (josernestodavila)]

Glipper 2.4 was supposed to be released on January (see comment #2 on this bug report), but it is not released yet. I'll get it touch with upstream and see if I backport the history.patch or wait for the release of 2.4

[Helmo (helmo)]

I had the same problem.

Applied the patch, build the package and it solved my problem. :)

Getting this into Precise would be great.

[Laszlo Pandy (laszlok)]

Hi, sorry. I'm still here and reading the comments. I forgot about the release, but will try and get it out this week.

[arv (arvind-vasudev2000)]

I just applied the patch on my system as well, and that does seem to solve the problem for me too.

[Bradley M. Froehle (brad-froehle)]

Since it's been a month without the promised release (and the patch suggested by @garrison-codefix six months ago) has not yet even made its way into the glipper source, I suggest we roll a glipper-2.3-1ubuntu1 deb.

To make the packagers life even easier, I've attached a debdiff.

[Alexandr Novel (normalex)]

bump bump

[José Ernesto Dávila Pantoja (josernestodavila)]

2012/6/7 Bradley M. Froehle <email address hidden>:
> Since it's been a month without the promised release (and the patch
> suggested by @garrison-codefix six months ago) has not yet even made its
> way into the glipper source, I suggest we roll a glipper-2.3-1ubuntu1
> deb.

I prefer to upload the changes to debian unstable and then sync the
package to ubuntu and find a way to backport the fix to precise.

> To make the packagers life even easier, I've attached a debdiff.
>
> ** Patch added: "904367-problems_when_ctrl_c_item_is_None.debdiff"
>   https://bugs.launchpad.net/glipper/+bug/904367/+attachment/3180220/+files/904367-problems_when_ctrl_c_item_is_None.debdiff
>

Good job! And thanks for making my life easier ;-) I just tweaked the
debian/changelog (the patch name was incorrect).

--
José Ernesto Dávila Pantoja
Licenciado en Computación
---------------------------------------------------------------------------------------------
Ubuntu Member
Ubuntu User #395356
GNU/Linux User #18273
Blog: http://josernestodavila.blogspot.com/
Fingerprint: 42F6 CCA0 22B2 B64C 131D  AA9C 5943 CDFE 99BC D948
---------------------------------------------------------------------------------------------

[Jeremy Bícha (jbicha)]

This bug was fixed in the package glipper - 2.3-3
Sponsored for Bradley M. Froehle (brad-froehle)

---------------
glipper (2.3-3) unstable; urgency=medium

  [ Bradley M. Froehle ]
  * debian/patches:
    - Add ctrl_c_item-is-None.patch (LP: #904367)

 -- Jose Ernesto Davila Pantoja <email address hidden> Tue, 19 Jun 2012 10:12:27 -0600

[Bradley M. Froehle (brad-froehle)]

Great! Can this be uploaded to precise-proposed?

[José Ernesto Dávila Pantoja (josernestodavila)]

2012/7/23 Bradley M. Froehle <email address hidden>:
> Great! Can this be uploaded to precise-proposed?

I think it is possible (and I want to). I have to RTFM on SRU
(https://wiki.ubuntu.com/StableReleaseUpdates#Universe) to propose
this update for precise.

--
José Ernesto Dávila Pantoja

[Teo (teo1978)]

So how do we get the fix?

[Thomas Novin (thomasn80)]

Is there a deb available for download so we don't have to wait?

[José Ernesto Dávila Pantoja (josernestodavila)]

2012/8/3 ThomasNovin <email address hidden>:
> Is there a deb available for download so we don't have to wait?

I've not tested yet, but I'm pretty sure that quantal .deb will work
fine on precise. I promise to upload a .deb for precise on monday.

Greets,

--
José Ernesto Dávila Pantoja

[Massimiliano Ballerini (mballerini)]

I think i'm gonna disable glipper meanwhile, everytime I log-in it keep crashing and I have to killall glipper, since the button "don't restart it" in the ubuntu error report seems to have no effect. It keep crashing and restarting till you kill it.

Please share the fix if you have, I use ubuntu at work and glipper is very useful. :)

[José Ernesto Dávila Pantoja (josernestodavila)]

I finally uploaded a version of glipper for precise to my ppa, ppa:josernestodavila/motu. I installed and tested it all day and it's working as it should.

[Laszlo Pandy (laszlok)]

Glipper 2.4 has been released, and a package is available in the PPA:
https://launchpad.net/~glipper-drivers/+archive/ppa

[Teo (teo1978)]

I have Update Manager working and I accept and install all the updates it finds daily, and still I'm not getting this fix.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Julian Taylor (jtaylor)]

I have uploaded the fix to precise-proposed, please test it when it is accepted

[Colin Watson (cjwatson)]

Hello Garrison, or anyone else affected,

Accepted glipper into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/glipper/2.3-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Bradley M. Froehle (brad-froehle)]

I have run through several test cases and can confirm that the package in precise proposed successfully fixes this crash. Thanks all!

$ apt-cache policy glipper
glipper:
  Installed: 2.3-1ubuntu0.1
  Candidate: 2.3-1ubuntu0.1
  Version table:
 *** 2.3-1ubuntu0.1 0
        400 http://us.archive.ubuntu.com/ubuntu/ precise-proposed/universe amd64 Packages
        100 /var/lib/dpkg/status
     2.3-1 0
        500 http://us.archive.ubuntu.com/ubuntu/ precise/universe amd64 Packages

[Scott Kitterman (kitterman)]

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package glipper - 2.3-1ubuntu0.1

---------------
glipper (2.3-1ubuntu0.1) precise-proposed; urgency=low

  * debian/patches:
    - Add 904367-ctrl_c_item-is-None.patch (LP: #904367)
      fixes crash when used with empty clipboard
 -- <email address hidden> (Bradley M. Froehle) Wed, 09 May 2012 08:51:15 -0700