Database can not created after import/put a zip file(module) into our addons directory

[SnippetBucket.com]

When I am going to create new db with latest server code.

[2011-12-14 12:52:09,991][?] INFO:server:OpenERP server is running, waiting for connections...
[2011-12-14 12:52:09,991][?] INFO:wsgi:HTTP service (werkzeug) running on 0.0.0.0:8069
[2011-12-14 12:52:31,979][template1] INFO:db.create:CREATE DATABASE picking11
[2011-12-14 12:52:35,446][picking11] ERROR:db.create:CREATE DATABASE failed:
Traceback (most recent call last):
  File "/home/tiny/sources/openobject-server/openerp/service/web_services.py", line 60, in _initialize_db
    openerp.modules.db.initialize(cr) # TODO this should be removed as it is done by pooler.restart_pool.
  File "/home/tiny/sources/openobject-server/openerp/modules/db.py", line 61, in initialize
    info = openerp.modules.load_information_from_description_file(i)
  File "/home/tiny/sources/openobject-server/openerp/modules/module.py", line 262, in load_information_from_description_file
    with tools.file_open(terp_file) as terp_f:
AttributeError: 'cStringIO.StringO' object has no attribute '__exit__'

[Amit Parik (amit-parik)]

Hello,

This problem is version specific and only reproducible in ubuntu 10.10 as well as ubuntu 11.10.

Thanks for reporting!

[Amit Parik (amit-parik)]

Hello,

Please ignore the comment#1, currently it is only reproducible in unbuntu 10.10 with web addons path.

I have attached a video for more reference so would you please check it.

Thank you!

[Naresh(OpenERP) (nch-openerp)]

Hello,

This does not seems to be reproducible I would mark this as invalid , please feel free to open the bug if you find the problem still exists with the latest trunk code with relavant useful information of the steps and environment you are using !

Thanks for understanding !

Regards,

[Amit Parik (amit-parik)]

Hello Naresh,

This bug is reproducible in all version so I am wrong on my comment#1 is that "It is version specific".\

But exact issue is not that, I have again reproduce this same issue with all version which steps are below.

1) Create one module and also create this module's zip file.
2) Put this file in to your addons directory or try to import module and see this zip module now appears in your addons directory.
3) Try to create a new database you will faced the above error.

So according to this precious steps I am reopening this bug.

Thank you!

[Amit Parik (amit-parik)]

Hello,

This problem is still persist, But I have applied the patch of lp:911603, which described the same problem (Will duplicate it).

Those patch is correct and it's working fine, So I requesting that on the fixing time please consider the lp:911603 's patch.

Thanks for understanding!

[Chris Forbes (chrisf-ijw)]

Still broken in -rc1. Can you please merge the patch from lp:911603 sometime?

[Chris Forbes (chrisf-ijw)]

From a quick look at the runbot, it appears there is *no* test coverage on the code for zip module import. This would have shown up this bug -- shall I prepare another patch which adds a test for this area?

[Chris Forbes (chrisf-ijw)]

Fixed in openobject-server trunk rev #4003.

[Antony Lesuisse (OpenERP) (al-openerp)]

As mentioned by chris this is fixed in 4003 revid:<email address hidden> remove contextmanger

[Antony Lesuisse (OpenERP) (al-openerp)]

@Chris Forbes: Yes of course a merge prop with a test case is always welcome.