nova-milestone-tarball job fails

[Thierry Carrez]

https://jenkins.openstack.org/view/Milestone-proposed/job/nova-milestone-tarball/74/

nova-milestone-tarball job fails for the following reason:
mv: cannot stat `jenkins-artifacts/branch=,label=build/venv.tgz': No such file or directory

This is blocking E2 release.

Note that the same error blocks the nova-docs job, preventing nova-tarball to run for master builds:
https://jenkins.openstack.org/view/Nova/job/nova-docs/1771/console

[Monty Taylor (mordred)]

There are two things here:

1 ) nova-venv didn't have milestone-proposed in the list of venvs that it builds. Oops.

2) template-nova-copy-venv assumed it was being called from a gerrit triggering context. nova-docs does not trigger from gerrit. So for now I added in a hack (if not GERRIT_BRANCH: GERRIT_BRANCH=master) but I don't know that I like that. soren suggested perhaps using GIT_BRANCH, but I have not tested to see if that would do the right thing.