"bzr pull" crashes in a branch created by bzr-git

[Eli Zaretskii]

With the latest bzr 2.5b4 beta, and bzr-git/dulwich that come with it, "bzr pull" crashes in every branch cloned from a git repo. Here's an example from the GDB repository (let me know if you need more information):

D:\usr\eli\bzr\gdb.git>bzr pull
Using saved parent location: git://sourceware.org/git/gdb.git
bzr: ERROR: exceptions.TypeError: open_branch() got an unexpected keyword argument 'possible_transports'

Traceback (most recent call last):
  File "bzrlib\commands.pyo", line 923, in exception_to_return_code
  File "bzrlib\commands.pyo", line 1128, in run_bzr
  File "bzrlib\commands.pyo", line 676, in run_argv_aliases
  File "bzrlib\commands.pyo", line 698, in run
  File "bzrlib\cleanup.pyo", line 135, in run_simple
  File "bzrlib\cleanup.pyo", line 165, in _do_with_cleanups
  File "bzrlib\builtins.pyo", line 1089, in run
  File "bzrlib\branch.pyo", line 180, in open
TypeError: open_branch() got an unexpected keyword argument 'possible_transports'

bzr 2.5b4 on python 2.6.6 (Windows-XP-5.1.2600-SP2)
arguments: ['bzr', 'pull']
plugins: bisect[1.1.0dev], bzrtools[2.4.1], changelog_merge[2.5b4],
    colo[0.3.1dev], encdiff[1.0.0], explorer[1.1.0], fastimport[0.12.0dev],
    git[0.6.6dev], grep[0.4.0], history_db[unknown], keywords[unknown],
    launchpad[2.5b4], loom[2.2.1dev], netrc_credential_store[2.5b4],
    news_merge[2.5b4], pipeline[1.1.0], qbzr[0.18.6], rewrite[0.6.3dev],
    svn[1.1.1], tiplog[0.0.5dev], upload[1.0.1dev], xmloutput[0.8.8]
encoding: 'cp1255', fsenc: 'mbcs', lang: None

[Eli Zaretskii (eliz)]

Thanks for the quick fix.

Since this bug effectively disables bzr-git in bzr 2.5b4, would it be possible to have a minimal patch for bzr-git 0.6.5 that fixes the crash?

[Jelmer Vernooij (jelmer)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/14/2011 02:18 PM, Eli Zaretskii wrote:
> Thanks for the quick fix.
>
> Since this bug effectively disables bzr-git in bzr 2.5b4, would it be
> possible to have a minimal patch for bzr-git 0.6.5 that fixes the crash?
I've just 0.6.6, which includes the fix.

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJO6j6zAAoJEACAbyvXKaRXC+kP/RAkAjxKt857dqyb/DEhDuXC
3lWpasx2fBimBeoOoO4O3H/OBP3FXw2HKkY4fJsv50jBpoC14MTBGCa0stIeu2bu
cUevudejv/ySJa3vQD2kT0pyH3vJrxbTG317VX/mPYXbLAtlIHwA8M9Q5lEdOBZH
KUbOKUK2DKZfSyBTWhvCcgCp/r6HiJqskUOkz23OuWH5KzLHF3e3FK/7i1MOzvwA
1HgHyAj5Jc7vybUWFfc8aetyZtbHz6O/h4Ij60TIw9WKzwuubDqIRbmuZgn+lzu+
IqjIwMWJspgmCkUDghyfVPy/vOB3Kqr75lyJFJWlotEAUy1j7mket4tSj1aMfeOq
kur8YxnV8wpuyQ1x9NTqbeQymV4BMZo+1Um65epud3ab1Tf9VNXnxKECcNZ833gV
MKz8PZiNk5c8TsSrNSRYbvI1+/vO9s4q9N7/DOoGkVXlUYswkcObEYB+0JWW0aAQ
I8NIbUCfcmyf/tID291OkO3snsQ+EM8Lk+DQfDBd0I8xun0QBRhqj3TWb4sieNX5
oas5U+OHAtajD+ECTOeq8EZKswYlCWsQEgg3CD+XZVbnuxfVDZywAws9UqlKqtgi
m3mISkM91eUxYjQhbGPPNfZHlZL1cOSezCVKw6n2wawjzv6oVpRVgefYRFpTF1A4
VVy4+ALbmgUnirrksdi0
=EdWn
-----END PGP SIGNATURE-----