Mahara

Auth plugins have lots of duplicated code

Bug #904065 reported by François Marier
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Triaged
Medium
Unassigned

Bug Description

Core authentication plugins (e.g. XMLRPC, SAML and LDAP) have a significant amount of duplicated code which could lead to certain checks not being performed correctly.

We should look at refactoring some of it to make these plugins more robust and easier to maintain. It will also make it much easier for contrib plugins that have to extend the same API.

Tags: auth security
François Marier (fmarier)
Changed in mahara:
milestone: 1.5.0 → none
Revision history for this message
Ruslan Kabalin (rkabalin) wrote :

There are also some duplicates in the core auth lib I have spotted.

Revision history for this message
Son Nguyen (ngson2000) wrote :

The tool PMD/CPD (http://pmd.sourceforge.net/cpd.html) to detect code duplicates is quite helpful

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.