pt-tcp-model crashes in --type=requests mode on empty file
Bug #903510 reported by
Baron Schwartz
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Brian Fraser |
Bug Description
It looks to me like pt-tcp-model is not handling an empty file here:
[baron@ginger ~]$ touch foo
[baron@ginger ~]$ pt-tcp-model --type=requests foo
Use of uninitialized value in numeric lt (<) at /home/baron/
Related branches
lp:~percona-toolkit-dev/percona-toolkit/fix-903510-pt-tcp-model-empty-requests-file
- Daniel Nichter: Approve
-
Diff: 65 lines (+22/-4)3 files modifiedbin/pt-tcp-model (+4/-1)
lib/TCPRequestAggregator.pm (+4/-1)
t/pt-tcp-model/analyses.t (+14/-2)
tags: | added: crash pt-tcp-model |
Changed in percona-toolkit: | |
status: | New → Confirmed |
Changed in percona-toolkit: | |
status: | Confirmed → Fix Committed |
importance: | Undecided → Medium |
assignee: | nobody → Brian Fraser (fraserbn) |
milestone: | none → 2.1.3 |
summary: |
- pt-tcp-model throws an error in --type=requests mode on empty file + pt-tcp-model crashes in --type=requests mode on empty file |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/ /jira.percona. com/browse/ PT-446