Unit test errors on Python 2.6

[Lorin Hochstein]

Some unit tests are erroring out on Python 2.6.x because its unittest doesn't have a skip method:

To replicate (Python 2.6.6 on RHEL 6.1):

$ ./run_tests.sh test_cfg
Failure
    runTest ERROR

======================================================================
ERROR: Failure: AttributeError ('module' object has no attribute 'skip')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/lorin/nova/.nova-venv/lib/python2.6/site-packages/nose/loader.py", line 379, in loadTestsFromName
    module = resolve_name(addr.module)
  File "/home/lorin/nova/.nova-venv/lib/python2.6/site-packages/nose/util.py", line 321, in resolve_name
    module = __import__('.'.join(parts_copy))
  File "/home/lorin/nova/nova/tests/test_cfg.py", line 155, in <module>
    class ConfigFileOptsTestCase(BaseTestCase):
  File "/home/lorin/nova/nova/tests/test_cfg.py", line 340, in ConfigFileOptsTestCase
    @unittest.skip('FIXME(markmc): values spread across the CLI and multiple '
AttributeError: 'module' object has no attribute 'skip'

----------------------------------------------------------------------
Ran 1 test in 0.001s

FAILED (errors=1)

[Soren Hansen (soren)]

Fixing that is simple enough (replace unittest.skip with test.skip_test), but there's 38 other errors that I think are due to python2.6 compatibility. :(

[Kevin L. Mitchell (klmitch)]

To summarize:

* ConfigParser.SafeConfigParser() does not take allow_no_value as a keyword argument (nova/common/cfg.py:1019, _parse_config_files()
* There is no assertRaisesRegexp() in Python 2.6 (nova/tests/test_cfg.py:135, 143, 598, 608, 623, 629, 640, 653, 663, 679, 685, 712, 717, 723, 728)
* There is no assertIsNone() in Python 2.6 (nova/tests/test_cfg.py:785, 786, 787)

[Vish Ishaya (vishvananda)]

eww.

We need jenkinst to run unittests on 2.6 as well so we stop breaking this.

On Dec 8, 2011, at 7:55 AM, Lorin Hochstein wrote:

> Public bug reported:
>
> Some unit tests are erroring out on Python 2.6.x because its unittest
> doesn't have a skip method:
>
> To replicate (Python 2.6.6 on RHEL 6.1):
>
> $ ./run_tests.sh test_cfg
> Failure
> runTest ERROR
>
> ======================================================================
> ERROR: Failure: AttributeError ('module' object has no attribute 'skip')
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/lorin/nova/.nova-venv/lib/python2.6/site-packages/nose/loader.py", line 379, in loadTestsFromName
> module = resolve_name(addr.module)
> File "/home/lorin/nova/.nova-venv/lib/python2.6/site-packages/nose/util.py", line 321, in resolve_name
> module = __import__('.'.join(parts_copy))
> File "/home/lorin/nova/nova/tests/test_cfg.py", line 155, in <module>
> class ConfigFileOptsTestCase(BaseTestCase):
> File "/home/lorin/nova/nova/tests/test_cfg.py", line 340, in ConfigFileOptsTestCase
> @unittest.skip('FIXME(markmc): values spread across the CLI and multiple '
> AttributeError: 'module' object has no attribute 'skip'
>
> ----------------------------------------------------------------------
> Ran 1 test in 0.001s
>
> FAILED (errors=1)
>
> ** Affects: nova
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are subscribed to
> OpenStack Compute (nova).
> https://bugs.launchpad.net/bugs/901730
>
> Title:
> Unit test errors on Python 2.6
>
> Status in OpenStack Compute (Nova):
> New
>
> Bug description:
> Some unit tests are erroring out on Python 2.6.x because its unittest
> doesn't have a skip method:
>
> To replicate (Python 2.6.6 on RHEL 6.1):
>
> $ ./run_tests.sh test_cfg
> Failure
> runTest ERROR
>
> ======================================================================
> ERROR: Failure: AttributeError ('module' object has no attribute 'skip')
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/lorin/nova/.nova-venv/lib/python2.6/site-packages/nose/loader.py", line 379, in loadTestsFromName
> module = resolve_name(addr.module)
> File "/home/lorin/nova/.nova-venv/lib/python2.6/site-packages/nose/util.py", line 321, in resolve_name
> module = __import__('.'.join(parts_copy))
> File "/home/lorin/nova/nova/tests/test_cfg.py", line 155, in <module>
> class ConfigFileOptsTestCase(BaseTestCase):
> File "/home/lorin/nova/nova/tests/test_cfg.py", line 340, in ConfigFileOptsTestCase
> @unittest.skip('FIXME(markmc): values spread across the CLI and multiple '
> AttributeError: 'module' object has no attribute 'skip'
>
> ----------------------------------------------------------------------
> Ran 1 test in 0.001s
>
> FAILED (errors=1)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/nova...

[Kevin L. Mitchell (klmitch)]

Vish: +10000; this kind of breakage happens all the time.

[Lorin Hochstein (lorinh)]

Vish, Kevin: I filed a bug with openstack-ci about Jenkins running unit tests against 2.6.

https://bugs.launchpad.net/openstack-ci/+bug/901952

[Lorin Hochstein (lorinh)]

Fixed here: https://review.openstack.org/2208