Launchpad itself

New bug listings need to preload more attributes

Bug #901122 reported by William Grant
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Deryck Hodge

Bug Description

The beta bug listings use more data than the old ones, but don't preload all of it. This leads to lots of wasted SQL time, causing new timeouts. Notable omissions are bug.owner, bug.tags and bug.linked_branches. See the OOPSes for more details, including tracebacks.

Old: OOPS-bff1debc57d861c6bfc3245a373ee7c0
New: OOPS-22be944a946b54a7e06a56a3651a6a40.

Related branches

lp:~deryck/launchpad/preload-tags-for-buglistings-901122
Robert Collins (community): Approve
Diff: 201 lines (+58/-7)
7 files modified
lib/lp/bugs/browser/bugtask.py (+10/-2)
lib/lp/bugs/browser/cvereport.py (+2/-1)
lib/lp/bugs/browser/tests/test_bugtask.py (+4/-3)
lib/lp/bugs/doc/bugtask.txt (+15/-0)
lib/lp/bugs/interfaces/bugtask.py (+6/-0)
lib/lp/bugs/model/bugtask.py (+18/-0)
lib/lp/registry/browser/milestone.py (+3/-1)
lp:~deryck/launchpad/adapt-badges-listing-item-901122
Steve Kowalik (community): Approve (code)
Diff: 50 lines (+28/-1)
2 files modified
lib/lp/bugs/browser/bugtask.py (+1/-1)
lib/lp/bugs/browser/tests/test_bugtask.py (+27/-0)
lp:~deryck/launchpad/buglistings-preload-people-901122
Aaron Bentley (community): Approve
Diff: 284 lines (+83/-24)
7 files modified
lib/lp/bugs/browser/bugtask.py (+13/-5)
lib/lp/bugs/browser/cvereport.py (+5/-3)
lib/lp/bugs/browser/tests/test_bugtask.py (+26/-11)
lib/lp/bugs/interfaces/bugtask.py (+6/-0)
lib/lp/bugs/model/bugtask.py (+13/-0)
lib/lp/registry/browser/milestone.py (+13/-2)
lib/lp/registry/browser/tests/test_milestone.py (+7/-3)
Deryck Hodge (deryck)
Changed in launchpad:
assignee: nobody → Deryck Hodge (deryck)
Deryck Hodge (deryck)
Changed in launchpad:
status: Triaged → In Progress
Revision history for this message
Andreas Moog (ampelbein) wrote :

Are these timeouts accessing my bugs page (https://bugs.launchpad.net/~amoog) related? Or should I report a new bug:

OOPS-6d3d733bb0b508dfc518c09b5129fb9d
OOPS-5282105daa77c1a1eab48db30d7948cd
OOPS-6fcab1c69ddbb72987873d7ff0353608

Revision history for this message
William Grant (wgrant) wrote :

Andreas, those are a combination of this and bug #901124.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r14887 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14887) is part of this bug's fix.

tags: added: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r14889 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14889>.

Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Deryck Hodge (deryck) wrote :

I'm marking this qa-ok for the current changes. But after deploy, we need to mark it back to triaged. This is not completely fixed yet. The people queries for assignee and reporter didn't show up locally for me the way they do on production. In fact, one attempt to fix reporter seemed to generate more queries even locally. So I'll look again at assignee and reporter and get a branch going for those attributes.

Here's a recent OOPs from qastaging that makes the assignee/reporter issues very clear:
OOPS-2cc66f8467712f7347cba0be135ad420

tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r14983 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14983>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Deryck Hodge (deryck)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.