android deploy does not fail if untar fails
Bug #900990 reported by
Alexander Sack
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| LAVA Dispatcher |
Fix Released
|
High
|
Michael Hudson-Doyle | ||
Bug Description
the following android job is green even though untarring the system.tar.bz2 succeeded:
That's obvsiously a wrong result. This step must not be green if untar fails. Please use this opportunity to review android deploy error handling from ground up i guess.
Related branches
lp:~mwhudson/lava-dispatcher/bug-900990
- Paul Larson (community): Approve
-
Diff: 75 lines (+20/-18)1 file modifiedlava_dispatcher/client/master.py (+20/-18)
| description: | updated |
Revision history for this message
| Paul Larson (pwlars) wrote | #1 |
| Changed in lava-dispatcher: | |
| importance: | Undecided → High |
| milestone: | none → 2011.12 |
| status: | New → Triaged |
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | #2 |
| Changed in lava-dispatcher: | |
| status: | Triaged → Fix Released |
| Changed in lava-dispatcher: | |
| assignee: | nobody → Michael Hudson-Doyle (mwhudson) |
To post a comment you must log in.
In this case, the reason the deploy failed was due to an unsuccessful or incomplete download of system.tar.bz2 from android-build. The failure to extract it should have generated a critical exception like we do on the ubuntu deployment path, causing it to discontinue subsequent steps and skip straight to submitting results.