Quantum Manager does not expose flag for IP injection

[dan wendlandt]

Currently the Quantum Manager does not expose a flag that let's the administrator control whether IPs are injected into VMs.

The FlatManager has the flat_injected flag... we could either use that flag, or create an equivalent flag.

Currently the QuantumManager just sets 'injected' to True all the time.

[Salvatore Orlando (salvatore-orlando)]

If I remember correctly how IP allocation and injection works in nova, this probably means that at the moment DHCP is useless with QuantumManager, as addresses are always statically assigned to VMs.

[dan wendlandt (danwent)]

It probably depends on the image. For many images used, IP injection
fails and DHCP is definitely required. But yes, definitely want to
get this fixed.

Dan

On Thu, Feb 2, 2012 at 2:09 AM, Salvatore Orlando
<email address hidden> wrote:
> If I remember correctly how IP allocation and injection works in nova,
> this probably means that at the moment DHCP is useless with
> QuantumManager, as addresses are always statically assigned to VMs.
>
> --
> You received this bug notification because you are a member of Netstack
> Core Developers, which is subscribed to quantum.
> https://bugs.launchpad.net/bugs/900864
>
> Title:
>  Quantum Manager does not expose flag for IP injection
>
> Status in OpenStack Quantum (virtual network service):
>  New
>
> Bug description:
>  Currently the Quantum Manager does not expose a flag that let's the
>  administrator control whether IPs are injected into VMs.
>
>  The FlatManager has the flat_injected flag... we could either use that
>  flag, or create an equivalent flag.
>
>  Currently the QuantumManager just sets 'injected' to True all the
>  time.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/quantum/+bug/900864/+subscriptions

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira Networks: www.nicira.com
twitter: danwendlandt
~~~~~~~~~~~~~~~~~~~~~~~~~~~

[dan wendlandt (danwent)]

From talking to Alejandro, it seems like a recent commit removed our hack that always set network['injected'] = True, so now the field isn't set at all. Should be simple just to set this file based on the flag.

[Mercadolibre CloudBuilders (cloudbuilders-n)]

We are taking care of this issue, and will be commiting a fix.

[Mercadolibre CloudBuilders (cloudbuilders-n)]

Dan et. al.
Please can you propose us to be able to commit into the nova trunk ?
If you want to commit it, the change would be :

( proposed by Dan )
--- a/nova/network/quantum/manager.py
+++ b/nova/network/quantum/manager.py
@@ -480,6 +480,7 @@ class QuantumManager(manager.FloatingIP, manager.FlatManager):
                            'uuid': network['uuid'],
                            'bridge': '', # Quantum ignores this field
                            'label': network['label'],
+ 'injected': FLAGS.flat_injected,
                            'project_id': net_tenant_id}
                 networks[vif['uuid']] = network

[dan wendlandt (danwent)]

Hi! You should just be able to proposed the patch to nova for review following the instructions in:

http://wiki.openstack.org/HowToContribute
http://wiki.openstack.org/GerritWorkflow

Happy to help answer questions, or you can just ping the list, as anything that is unclear from the wiki pages should be updated to be more clear.

[dan wendlandt (danwent)]

Hi folks, did this bug ever make it in? If not, we can have someone else take care of it.

[Mercadolibre CloudBuilders (cloudbuilders-n)]

Dan, we suggested the patch in the last post, since we can commit it, feel free to propose the change for us, its very little and its tested.

Regards

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/4487

[David Lapsley (dlapsley)]

Hi folks, I pushed this for review last night. Thanks for the patch!

Dave.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/4487
Committed: http://github.com/openstack/nova/commit/86e9269015638511ee4c6960bd0cbbf7b01c603b
Submitter: Jenkins
Branch: master

commit 86e9269015638511ee4c6960bd0cbbf7b01c603b
Author: Dave Lapsley <email address hidden>
Date: Thu Feb 23 21:09:05 2012 -0500

    Fix bug 900864 Quantum Manager flag for IP injection.

    Re-uses FlatManager flat_injected flag to enable/disable
    IP injection in QuantumManager.

    Change-Id: I52c7a2c3aed452045cadb2282a59851c1083a812