Traceback when you edit a song twice

[Andreas Preikschat]

Hello,

1) Edit a song (right click -> edit)
2) Close the dialog by clicking "Save"
3) Edit a song again (right click -> edit)

Result:
A traceback is shown.

**OpenLP Bug Report**
Version: {u'full': u'1.9.5-bzr1421', u'version': u'1.9.5', u'build': u'bzr1421'}

--- Exception Traceback ---
Traceback (most recent call last):
  File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/songs/lib/mediaitem.py", line 371, in onEditClick
    self.editSongForm.loadSong(item_id, False)
  File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/songs/forms/editsongform.py", line 229, in loadSong
    self.loadMediaFiles()
  File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/songs/forms/editsongform.py", line 184, in loadMediaFiles
    plugin.getMediaManagerItem().getList(MediaType.Audio))
  File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/plugin.py", line 220, in getMediaManagerItem
    self.icon)
  File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/media/lib/mediaitem.py", line 58, in __init__
    MediaManagerItem.__init__(self, parent, plugin, icon)
  File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 112, in __init__
    self.setupUi()
  File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 201, in setupUi
    self.addListViewToToolBar()
  File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/media/lib/mediaitem.py", line 116, in addListViewToToolBar
    MediaManagerItem.addListViewToToolBar(self)
  File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 270, in addListViewToToolBar
    self.onDeleteClick, [QtCore.Qt.Key_Delete])
  File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/ui.py", line 375, in context_menu_action
    action_list.add_action(action)
  File "/home/andreas/Projekte/openlp/trunk/openlp/core/utils/actions.py", line 257, in add_action
    if self._shortcut_available(existing_actions, action):
  File "/home/andreas/Projekte/openlp/trunk/openlp/core/utils/actions.py", line 321, in _shortcut_available
    if existing_action.parent() is action.parent():
RuntimeError: underlying C/C++ object has been deleted

--- System information ---
Plattform: Linux-3.1.4-1-ARCH-i686-Intel-R-_Pentium-R-_4_CPU_1.80GHz-with-glibc2.0

--- Library Versions ---
Python: 2.7.2
Qt4: 4.7.4
Phonon: 4.5.1
PyQt4: 4.8.6
SQLAlchemy: 0.7.2
SQLAlchemy Migrate: 0.7.1
BeautifulSoup: 3.2.0
lxml: 2.3.1
Chardet: 2.0.1
PyEnchant: 1.6.5
PySQLite: 1.0.1
Mako: 0.5.0
pyUNO bridge: 3.4

[Stevan Pettit (elderp-deactivatedaccount)]

I cannot duplicate this error on Windows

[John Cegalis (jseagull1)]

I get it on XP and Kubuntu.

[Wesley Stout (wesleystout)]

I have no issue on Arch Linux.

[Andreas Preikschat (googol-deactivatedaccount)]

Reverted the change which caused this. However, we still should improve the code (and the bug might still exist in similar forms). Will probably fixed together with #768495

[Andreas Preikschat (googol-deactivatedaccount)]

The bug itself should not be visible. I hope its fixed.