losing keyboard release events

[Daniel Schürmann]

If you press a keyboard key, then press a modifier key, then release the key, you will get the press event without modifier and the release event with modifier.

Example:
* Press and hold "1" for Sync, press and hold Shift, release 1.
-> Sync button is always lit.

[Daniel Schürmann (daschuer)]

I am working on a solution where the modifier key is only taken into account when pressing a key. The release event is always fired, matching to the press event.

There is still a problem with Mac OSX and keys with different letters like "1" and "!" because Max OSX does not report the native scan code of the keys. Mixxx does not know whether the letters are on the same key or not.

Maybe a Mac OSX expert has an Idea?

[Daniel Schürmann (daschuer)]

here it is:

[Daniel Schürmann (daschuer)]

New version: Missing return caused searching in library; silenced debug output.

[Daniel Schürmann (daschuer)]

Just tested on Win-XP. There seems to be an issue with ^ on German keyboards. I will have a look.

[Daniel Schürmann (daschuer)]

Here is a modified patch, solves an issue with autorepeat on WinXP. The dead key ^ issue is tracked in the separate bug #907199.

[Daniel Schürmann (daschuer)]

Bug #684501 was marked as duplicate of this bug. It was tagged as 1.10.1 milestone.
Should we so add this patch also to 1.10.1 as well?

[RJ Skerry-Ryan (rryan)]

patch looks good.. thanks!

[RJ Skerry-Ryan (rryan)]

RE: 1.10.1 -- I'd rather keep changes like this limited to 1.11.0 so that we don't accidentally break keyboard shortcuts for people just upgrading to 1.10.1 if there is a bug we don't realize yet.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6165