[fsck.minix ] segfault while recovering directory with lots of files

Bug #899243 reported by Joao Carreira
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
util-linux (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

fsck.minix (version V2) crashes when recovering a directory containing a high number of files (e.g., 9000 dummy files).

fsck.minix wrongly determines when a block is pointed by a triple indirect pointer, in the following line (in map_block2 function):

if (blknr >= 256 * 256) // this should be blknr <= 256 * 256

This error leads to a negative block number which leads to a wrong memory access and to a segmentation fault.

I have attached a patch that fixes the problem. I can provide a sample disk that exercises the error.

Revision history for this message
Joao Carreira (jokarreira) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Patch that fixes the error" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Changed in util-linux (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Phillip Susi (psusi) wrote :

It looks like this fix has been applied already.

Changed in util-linux (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.