JSON samples are (frequently) invalid

Bug #898353 reported by Dolph Mathews
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Dolph Mathews

Bug Description

I just noticed a commit which corrected invalid JSON syntax in a *.json sample file... the hard part should be ensuring the content of the sample makes sense, not that it's syntactically correct...

Anyway, the following two files currently contain invalid JSON:

    keystone/content/common/samples/endpointTemplateWithOnlyId.json
    keystone/content/common/samples/roles.json

This has also spurred complaints from RCB, while attempting to use our samples for testing.

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/1987
Committed: http://github.com/openstack/keystone/commit/8f21b2c1efe4020aabfa5388ce1cd5eabf85cef5
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit 8f21b2c1efe4020aabfa5388ce1cd5eabf85cef5
Author: Dolph Mathews <email address hidden>
Date: Wed Nov 30 14:26:06 2011 -0600

    Added JSON validator; fixed samples (bug 898353)

    - Fixed broken samples
    - Added command to validate all included *.json files
        ./run_tests.sh -j

    Change-Id: I06839e22a4408e7ff4b6f5b8ebd29a73fcc809cf

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: essex-2 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.