put "empty trash" on the bottom right

[Danielle Foré]

Instead of having the "empty trash" button on the top of the view, it should be placed in the bottom right-hand corner. This is more consistent with the "call to action" placement used in dialog boxes and makes the button more obvious. Additionally, it avoids moving the icon view when changing between another folder and the Trash.

[ammonkey (am-monkeyd)]

I am not fan of the idea, all the control buttons are upper. This is not a dialog box.

[Danielle Foré (danrabbit)]

Made a mockup of how this could look.

[Albert (optimisme)]

Are the mockup background and button colors fine?

[Danielle Foré (danrabbit)]

We should probably handle theming in egtk. I would set ".bottom-toolbar" in the code and then I can target something like ".view .bottom-toolbar" in the theme.

Oh and also ".noundo" for the button

[Albert (optimisme)]

Sorry, I moved it to the bottom but I don't know how to theme it :(

Also, if it is themed in egtk it wont be available for non elementary distributions using pantheon-files.

I removed myself from assignation.

[Jeremy Wootten (jeremywootten)]

At the moment this widget is added using the "add_extra_widget" function of the Slot. This is also used by the network plugin. It is easy to change Slot to add the extra widget to the bottom, but it would also effect the network plugin. If you want to able to put extra widget both at the top and the bottom of the Slot then that function would need an extra parameter (top or bottom).

[Danielle Foré (danrabbit)]

Since there's another report about removing "Connect to Server" in the "Entire Network" section (because it's now in the sidebar), I think it's probably fine.

[Danielle Foré (danrabbit)]

Just an update about classes. These days we'd probably be packing a "destructive-action" button into a Gtk.ActionBar

[Danielle Foré (danrabbit)]

Another update about classes. This would still be a Gtk.ActionBar, but with "Gtk.STYLE_CLASS_INLINE_TOOLBAR" and a button with "Gtk.STYLE_CLASS_DESTRUCTIVE_ACTION"