--m4-file and -m4-pcbdir arguments to gsch2pcb do nothing

[Peter TB Brett]

The '--m4-file FILE' option to gsch2pcb is supposed to "use" the specified M4 source FILE when the gsch2pcb backend generates footprints using M4. The '--m4-pcbdir DIR' option is supposed to set the M4 search path to DIR. Neither do anything at the moment.

gsch2pcb generates a snippet of Scheme code which is evaluated by gnetlist between loading the gsch2pcb gnetlist backend and running it. The generated snippet contains lines that look like:

(define m4-pcbdir DIRSTRING)
(define m4-files FILESTRING)

where FILESTRING is a space-separated list of M4 filenames. However, the gsch2pcb gnetlist backend never uses either of these variables. This was broken in commit 6d935086d299.

[Peter TB Brett (peter-b)]

Some further investigation indicates that the problem is worse than it initially appeared, and I've updated the bug description accordingly. However, it's obvious that no-one actually uses these options, since they were broken throughout the stable-1.6 series. What about removing them entirely?

[gpleda.org commit robot (gpleda-launchpad-robot)]

Bug was fixed by a commit
git master commit c5b473354b2340b42d1a48436fb4da113b34657f
http://git.gpleda.org/?p=gaf.git;a=commit;h=c5b473354b2340b42d1a48436fb4da113b34657f

commit c5b473354b2340b42d1a48436fb4da113b34657f
Author: Peter TB Brett <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gsch2pcb: Make --m4-file and -m4-pcbdir arguments work again.

    These options were broken in commit 6d935086d299, and haven't worked
    since before 1.6.x. Since no-one had reported it a bug in all that
    time, it's obvious that no-one was actually using them, and we could
    probably get away with just deleting them. But making them work again
    will work as well.

    Closes-bug: lp-897661