Patch - Changes to spinboxes' behaviour
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
I've created three patches:
[switch_
In options windows, I think the plus and minus signs should be inverted.
Usually is common to have minus on left side, and plus on the right
[change_
I think that the --/++ buttons should alway be active and if adding/removing 10 brings the value over/under the minimum/maximum, the value should stick to the limits. They will work like a fast-forward options.
[add_replacemen
Replaced "0 days" for replays with "never". Sorry, but no idea if other than adding the value I have to set the word to be translatable somewhere.
Just a question: is correct to add patches like bugs or should I post them on forums?
Related branches
- Nicolai Hähnle: Approve
- Tino: Approve
-
Diff: 39 lines (+4/-4)1 file modifiedsrc/ui_basic/spinbox.cc (+4/-4)
- Nicolai Hähnle: Approve
- Tino: Approve
-
Diff: 24 lines (+6/-2)1 file modifiedsrc/ui_basic/spinbox.cc (+6/-2)
- Nicolai Hähnle: Approve
- Tino: Approve
-
Diff: 11 lines (+1/-0)1 file modifiedsrc/ui_fsmenu/options.cc (+1/-0)
Changed in widelands: | |
status: | New → Fix Committed |
milestone: | none → build17-rc1 |
hey Angelo,
Contributions is always highly welcome! But adding patches to the bug-tracker or the forum has some major drawbacks. It is way easier to see what you did and to apply your changes, if you upload them to a branch on launchpad. Then you can add a merge request and someone can have a look and give you feedback or merge your changes to trunk.
We have a wikipage trying to describe how you use bzr :) wl.widelands. org/wiki/ BzrPrimer/
http://