icon view: keyboard navigation+rename widget need some love

[Marin Treselj]

Using keyboard to perform regular file-management tasks is next to impossible in Marlin:

1) left and right arrow-key scrolling doesn't propagate to the next row
2) Shift+arrow doesn't select next row/column if there is no item right bellow/next to the last selected one
3) right click keyboard button doesn't work
4) shortcut letters in the right-click menu don't work (they only select an item instead of running it)
5) Ctrl-X, Ctrl-C, Ctrl+V and Ctrl-A shortcuts don't work in Rename mode; using these shortcuts actually leads to a lot of trouble because it applies to the files (e.g cut or duplicate the file you're trying to rename)

[ammonkey (am-monkeyd)]

1) i guess you're talking about the icon view? yes the icon view could need some love.
2) can u develop a bit more pls? which view?
3) what is right click keyboard button ?
4) just tested, i don't see any problem here, it select and run the menu action. This is a gtk behavior nothing really to do with marlin's code.
5) fixed

[Marin Treselj (phyzik)]

Thanks for taking your time at this!

1) yes
2) ok, I'll write a simplest case to replicate (still talking about icon view)
- let's say you are browsing a folder with 2 rows of items, but the second row contains only one item
- first item in the first row is highlighted
- now you want to select the second item in the first row, too, so you press Shift+Left_Arrow (this works correctly)
- but if now you want to select the (only) item in the second row, pressing Shift+Down_Arrow doesn't work, because the currently highlighted item (second item of the first row) doesn't have any items straight bellow itself.

This method of selecting actually works properly when you start on the right side and select to the left.

I guess it's not even a bug, just a different approach to multiple items selection (compared to Nautilus that is unable so select items of the same column).

3) The keyboard button in question is this one: http://djbarney.files.wordpress.com/2008/05/right-click-key.jpg?w=434&h=236
I don't know how it's mapped, but I know it is as it works in every other program (like Firefox, LibreOffice and Nautilus)

4) I see - I guess it's just some weird error on my system...

5) hmmm - is it in daily? It still doesn't work for me. Plus, I noticed another issue of the "rename" mode - if the name takes more than 1 line, up/down arrows don't work (they should move the cursor accross the text lines)

[ammonkey (am-monkeyd)]

Thx for the informations.

Yes i confirm row navigation keyboard need some love in icon view. The rename widget (still in icon view) need some love too, got some bugs on long filenames the cursor can go out of the vision. no up and down possible movement in rename. This is a very complicated widget, maybe i should have made my life easier by just pop up a windows with a simple gtk entry (like thunar and pcmanfm does), i'll see what i can do with this widget.

about 5) it has been fixed very recently in rev 678 which is now available in dailies (since 4 hours).

[Marin Treselj (phyzik)]

I can confirm that the:
3) right-click button
4) shortcut letters in the right-click menu
5) Ctrl+X, Ctrl+C and Ctrl+V

have all been fixed. Great work!

Still missing, though, is Ctrl+A (in the Rename mode) - it selects all the icons instead of the whole item title.

[ammonkey (am-monkeyd)]

status fixreleased

[ammonkey (am-monkeyd)]

 status fixreleased

On 15 April 2013 15:33, am monkeyd <email address hidden> wrote:

> status fixreleased
>

[ammonkey (am-monkeyd)]

 status fixreleased