Translations import queue pages no longer show statuses
Bug #894690 reported by
Jeroen T. Vermeulen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Jeroen T. Vermeulen | ||
Ubuntu Translations |
Fix Released
|
Critical
|
Unassigned |
Bug Description
The translations import queue pages no longer show the status of each import queue entry.
Example page: https:/
We expect admins, Ubuntu coordinators, but also regular users to act on the statuses displayed on that page so it's essential that they be visible.
Related branches
lp:~jtv/launchpad/bug-894690
- Raphaël Badin (community): Approve
-
Diff: 28 lines (+4/-3)1 file modifiedlib/lp/translations/javascript/importqueue.js (+4/-3)
Changed in ubuntu-translations: | |
status: | New → Triaged |
importance: | Undecided → Critical |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-translations: | |
status: | Triaged → Fix Released |
To post a comment you must log in.
Apparent cause: Huw replaced the ugly style=" display: none" in lib/lp/ translations/ templates/ translation- import- queue-macros. pt with a nicer class="hidden".
But the code in lib/lp/ translations/ javascript/ importqueue. js, in function init_status_choice, tries to make the status visible by doing:
content_ box.setStyle( 'display' , '');
That won't work when the style isn't even set.
This is annoyingly hard to test for: you'd need a test with full-on TAL rendering to catch it. Which is way overkill, really.