Unable to select multiple bookmarks for moving/deleting

[Grzegorz G.]

When I want to delete multiple bookmarks i have to select one, delete, select next one, delete... The same applies to moving them. This is very user unfriendly. Make it possible to select multiple bookmarks by holding shift or ctrl.

[Cody Garver (codygarver)]

Is this still true?

[Grzegorz G. (grzesiek1e5)]

I'll have to install Midori and check. Or I'll download newest elementary OS ISO and check it by the way. Does Luna ship newest Midori?

[Cody Garver (codygarver)]

Luna does ship the latest.

[André Auzi (aauzi)]

It is still true with the git-master version (See attachment for version information)

I can fix it but would need a design decision.

At the moment the delete of a folder seems to only delete the folder entry in the database, leaving all its child entries orphaned.

For me this seems to be a bug as well. It would make the bookmark database grow infinitely.

The proper fix would probably be to implement a recursive delete.

One may not like such recursion and may want a confirmation message box to popup.

What would be the preferred behaviour?

1- recursively delete everything without message?
     After all the user knows what it does when he deletes a folder... (my choise.... it just does the asked job)
2- recursively delete non empty folders only after a user confirmation?
     with a confirmation message box poping up for each non empty folder,
     we can can have the options [Abort] [Yes for all] [No for all] [Yes] [No] in that case
3- do not delete non-empty folders?
     In that case we can keep the remaining folders in the selection
4- do as 3 with regular delete and as 1 with a Ctrl+<delete>?
     Probably a better choice than 1 but more difficult to "discover" for the user.

[André Auzi (aauzi)]

Oups, missed the version attachement for the previous comment

[Grzegorz G. (grzesiek1e5)]

IMO, considering HIG ( http://elementaryos.org/docs/human-interface-guidelines/user-workflow/always-provide-undo ), you should just hide folder and its contents from view, pretending it's deleted and show something like "Folder x deleted. Undo?". If user clicks undo, set visibility to true again. If not, after some time really delete the folder and its content. (But be sure to remember the hidden state and "real delete" countdown even after restarting Midori, or weird things may happen.)

And please, really allow multiple items selection with ctrl or shift, because I may have 100 bookmarks in folder and want to delete only 50 of them. If you don't know what I'm talking about, launch Files (in double click mode!) or Nautilus, hold ctrl or shift and click on some files.

[André Auzi (aauzi)]

I face the same problem therefore I understand the need.

The multi selection, including the Shift and Control modifiers keys is a standard feature of the GTK treeview object the bookmark panel is based on. It's just disabled at the moment. With some care I should not break it.

With the HIG spec guideline I previously overlooked (thanks for the link btw) the delete feature is not that complex. For my point of view it's basically behaviour 1 of comment #4 with some centralized way to allow undos that can come later... after some design thinking.

The real concern is the move feature.

The drag and drop feature in the GTK treeview being at moment limited to one row at a time, it needs some work to implement it.

As a bonus (and maybe to be forgiven for the time it'll take to develop that) I propose to allow the 'Open in new tabs' action on a multi selection ;)

[André Auzi (aauzi)]

Here is a first change proposal.

It is a big patch and the result seems pretty slow. It probably needs some stress testing before been shipped.

Other user/tester feedback is more than welcome.

[André Auzi (aauzi)]

The previous change broke the 'Open all in Tabs" action for folders.

This new one fixes it.

It applies to git-master and replaces the previous patch.

Let me know if an incremental patch is preferred.

[Danielle Foré (danrabbit)]

André, can you re-submit your patch in the form of a bzr branch merge request as outlined here: http://wiki.xfce.org/midori/contribute

This would allow us to review your changes more quickly :)

[André Auzi (aauzi)]

Done.

it's there: http://bazaar.launchpad.net/~aauzi/midori/bookmarks-work/revision/6164

The code evolved a little since the last drop. I attach the patch for whoever prefers this form of delivery.

It implements:
  * bookmarks panel multiple selection DND delete and moves
  * katze items signals between bookmarks panel and bookmarks bar
  * correct handling of panel position on database retrieval
  * bookmarkbar folder trees
  * bookmark folder path in bookmark edit combo box
  * use of current selection for bookmark/folder creation parent folder
  * status bar updates and popup menus cosmetics
  * idle time database updates (speed feeling)

It does not implement (future work):
  * DND exchanges between bookmark bar and bookmark panel
  * DND bookmark creation