Follow-up to OpenSHA logging cleanup
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenQuake (deprecated) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
In bug # 888013, we disabled some unnecessary logging.
In reviewing the changed files, I noticed several warnings and FindBugs errors. These aren't critical to fix; just a bit of house cleaning.
- Test for floating point equality: https:/
- Can be replaced with `if (((Double)
- invokes inefficient new Integer(int) constructor: https:/
- Can be replaced with `s.writeObject(
- ArbitrarilyDisc
- Dead store to fltType: https:/
- Dead store to component: https:/
- Abrahamson_
- Unused variable f4: https:/
- Static field COMPONENT_AVE_HORZ should be accessed in a static way: https:/
- Static field COMPONENT_AVE_HORZ should be accessed in a static way: https:/
- Should org.opensha.
class?
- Method org.opensha.
branches: https:/
- Should org.opensha.
class?
- Dead store to component: https:/
- Should org.opensha.
class?
- Unused imports: https:/
- Unused commented-out code: https:/
Changed in openquake: | |
status: | New → Fix Released |