bzr selftest crashed with ImportError: cannot import name Feature

[Matt Giuca]

Trying to run the bzr test suite from trunk. It no longer runs for me (on a fresh branch, after building), crashing with "cannot import name Feature".

This was introduced in trunk r6043 (more specifically, r5967.12.1). If I run selftest on r6042 or r5967, it is fine. r6043 or r5967.12.1 both cause this error.

To reproduce:
$ bzr branch lp:bzr test-trunk
$ cd test-trunk
$ ./setup.py build
$ ./bzr selftest

ProblemType: Crash
DistroRelease: Ubuntu 11.04
Package: bzr 2.3.4-0ubuntu1
ProcVersionSignature: Ubuntu 2.6.38-12.51-generic 2.6.38.8
Uname: Linux 2.6.38-12-generic i686
NonfreeKernelModules: nvidia
Architecture: i386
BzrDebugFlags: set()
BzrVersion: 2.5.0dev1
CommandLine: ['./bzr', 'selftest']
CrashDb: bzr
Date: Sun Nov 20 10:52:32 2011
EcryptfsInUse: Yes
ExecutablePath: /home/matt/src-pkg/bzr/oldtrunk/bzr
FileSystemEncoding: UTF-8
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release i386 (20100429)
InterpreterPath: /usr/bin/python2.7
Locale: en_AU.UTF-8
PackageArchitecture: all
Platform: Linux-2.6.38-12-generic-i686-with-Ubuntu-11.04-natty
ProcCmdline: python ./bzr selftest
ProcEnviron:
 SHELL=/bin/bash
 PATH=(custom, user)
 LANG=en_AU.UTF-8
 LANGUAGE=en_AU:en
PythonVersion: 2.7.1
SourcePackage: bzr
Title: bzr crashed with ImportError in /usr/lib/python2.7/dist-packages/bzrlib/plugins/fastimport/tests/__init__.py: cannot import name Feature
UpgradeStatus: Upgraded to natty on 2011-04-29 (204 days ago)
UserEncoding: UTF-8
UserGroups: adm admin audio cdrom dialout lpadmin plugdev sambashare

[Martin Pool (mbp)]

You need an update to your bzr fastimport plugin.

I'm pretty sure this is fixed on trunk so probably the packaged version needs to be updated.

Arguable we should just revert the api break instead.

[Martin Pool (mbp)]

This will be fixed in the next beta; it doesn't need a specific fix in ubuntu.

[Martin Pool (mbp)]

I will restore the old name.

[Matt Giuca (mgiuca)]

Thanks Martin. I'm using bzr fastimport from the Natty packages, so that would explain it (different versions). For now, I just ran apt-get remove bzr-fastimport. Now the test suite works.

I'll leave this bug open so you can decide whether you want to address it or just leave it (since presumably the new version of Bazaar and the new version of bzr-fastimport are compatible).

[Martin Pool (mbp)]

We did re-add the old name.