can't display ID3 properties if original date is more precise than a year

Bug #892594 reported by Damien Thébault
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Low
Johannes Sasongko

Bug Description

Here is the output I get when right-clicking on a MP3 file I have and selecting "Properties":

> Traceback (most recent call last):
> File "/usr/lib64/exaile/xlgui/playlist.py", line 124, in <lambda>
> self.properties_dialog())
> File "/usr/lib64/exaile/xlgui/playlist.py", line 157, in properties_dialog
> tracks, selected)
> File "/usr/lib64/exaile/xlgui/properties.py", line 129, in __init__
> self._build_from_track(self.current)
> File "/usr/lib64/exaile/xlgui/properties.py", line 281, in _build_from_track
> self.rows.append(TagRow(self, self.tags_table, f, tag, entry, i))
> File "/usr/lib64/exaile/xlgui/properties.py", line 504, in __init__
> self.field.set_value(value, all_vals)
> File "/usr/lib64/exaile/xlgui/properties.py", line 694, in set_value
> self.field.set_value(float(val))
> ValueError: invalid literal for float(): 1981-10

In this MP3/ID3v2.4 file, the value 1981-10 is present in the "TDOR" frame.

The ID3v2.4 format defines the "TDOR" frame that contains the "Original release time".
This frame is similar to "TDRL" containing the "Release time" or "TDRC" containing the "Recording time".
Those frames can contain a date which precision can vary from just the year (yyyy), up to the full timestamp (yyyy-MM-ddTHH:mm:ss).

In exaile's xl/metadata/_id3.py, the "TDOR" frame is mapped on "originaldate" and "TDRC" is mapped on "date".
However, in xlgui/properties.py, "date" is displayed as a text but "originaldate" is displayed as an int.

If I set "originaldate" to be displayed as text like "date", then everything works as expected: the properties window shows up and I can see "Original date: [1981-10]" in the tag list.

Note: I generated this MP3's ID3 frame with eyeD3's option "--set-text-frame=TDOR:1981-10".

Exaile version v0.3.2.1 from Gentoo's official tree, exact package name is "media-sound/exaile-0.3.2.1"

Revision history for this message
Damien Thébault (damien-thebault) wrote :
Revision history for this message
Mathias Brodala (mathbr) wrote :

This has been fixed with r3893.1.43

Changed in exaile:
assignee: nobody → Johannes Sasongko (sjohannes)
importance: Undecided → Low
milestone: none → 0.3.3.0
status: New → Fix Committed
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.