Bad background in Slingshot

Bug #891893 reported by Cody Garver
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
elementary Stylesheet
Fix Released
Undecided
Unassigned

Bug Description

Somewhere sometime someone told me this was an egtk issue. See the attached screenshots. One is Ambiance, the other egtk.

Tags: gtk3 popover
Revision history for this message
Cody Garver (codygarver) wrote :
Revision history for this message
Cody Garver (codygarver) wrote :
Changed in egtk:
status: New → Invalid
Revision history for this message
Victor Martinez (victored) wrote :

We need to add the following code to the widget's stylesheet in granite:

GraniteWidgetsPopOver * {
    background-color: #f8f8f8;
}

And this code to egtk:

/* Fix for popover's sidebar */
GraniteWidgetsPopOver .sidebar.view
{
    background-color: #f8f8f8;
    /* TODO: theme borders */
}

As a temporal solution, both portions of the code could be included in egtk, but they should be removed as soon as the problem is fixed upstream.

Changed in egtk:
status: Invalid → Confirmed
Revision history for this message
Victor Martinez (victored) wrote :

We also need to use override_background_color() for every widget that is added to the popover. If we don't do that, every possible widget someone could add to a popover will have to be themed in egtk and other themes, which isn't a big deal.

tags: added: gtk3 popover
Changed in egtk:
status: Confirmed → Fix Committed
Revision history for this message
Victor Martinez (victored) wrote :

There's actually no bug in popovers. Since egtk has a nice custom styling, all the code will need to remain there :)

Changed in granite:
status: New → Invalid
no longer affects: granite
Changed in egtk:
milestone: none → 3.0
Changed in egtk:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.