Banner notifications are not shown if JavaScript is disabled.
Bug #891697 reported by
Aaron Bentley
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
j.c.sackett | ||
Bug Description
The beta and privacy banners should be shown regardless of whether you have JavaScript enabled, because users may be affected by beta features and private information even if they have JavaScript disabled.
Those with JavaScript disabled would not be able to dismiss the beta banner, so the close button should still be shown only to JavaScript users, but the remainder should be presented to everyone.
Related branches
lp:~jcsackett/launchpad/progressively-enhanced-banners
- Curtis Hovey (community): Approve (code)
-
Diff: 650 lines (+184/-97)19 files modifiedlib/canonical/launchpad/icing/css/base.css (+0/-4)
lib/canonical/launchpad/icing/css/components/beta_banner.css (+5/-4)
lib/canonical/launchpad/icing/css/components/global_notification.css (+2/-3)
lib/canonical/launchpad/icing/css/components/sidebar_components.css (+0/-10)
lib/lp/app/browser/configure.zcml (+7/-0)
lib/lp/app/browser/tales.py (+13/-15)
lib/lp/app/browser/tests/base-layout.txt (+8/-4)
lib/lp/app/browser/tests/test_formatters.py (+5/-3)
lib/lp/app/doc/tales.txt (+4/-4)
lib/lp/app/javascript/banners/banner.js (+2/-11)
lib/lp/app/javascript/banners/beta-notification.js (+3/-4)
lib/lp/app/javascript/banners/privacy.js (+1/-10)
lib/lp/app/javascript/banners/tests/test_banner.js (+1/-2)
lib/lp/app/javascript/banners/tests/test_beta_notification.js (+3/-4)
lib/lp/app/javascript/banners/tests/test_privacy.js (+1/-11)
lib/lp/app/templates/banner-macros.pt (+43/-0)
lib/lp/app/templates/base-layout.pt (+5/-1)
lib/lp/services/webapp/publisher.py (+32/-7)
lib/lp/services/webapp/tests/test_publisher.py (+49/-0)
| summary: |
- beta banner (and privacy banner?) should be rendered server-side + Beta banner is not shown if JavaScript is disabled. |
| summary: |
- Beta banner is not shown if JavaScript is disabled. + Banner notifications are not shown if JavaScript is disabled. |
| description: | updated |
| tags: | added: disclosure javascript privacy |
| Changed in launchpad: | |
| assignee: | nobody → j.c.sackett (jcsackett) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r15287 <http://