exhibit banner images are served via https

Bug #891084 reported by Michael Vogt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Software Center Agent
Fix Released
Undecided
Michael Nelson
software-center (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Hi,

the exhibit banners from software-center-agent are served via https. E.g.:
    {
        "package_names": "braid",
        "banner_url": "https://software-center.ubuntu.com/site_media/exhibits/2011/10/braid.png",
        "html": "<div style=\"\r\n background-color: #000;\r\n width:1600px;\r\n height:200px;\r\n \">\r\n <div style=\"\r\n width:900px;\r\n height:200px;\r\n background: url('/site_media/exhibits/2011/10/braid.png') top left no-repeat;\"\r\n>\r\n <h1 style=\"visibility:hidden;\">Braid</h1>\r\n </div>\r\n</div>",
        "published": true,
        "date_created": "2011-10-12 12:53:58",
        "id": 2
    }

This causes issues on some installs where no https support for gio/glib is installed (yes, that is rather silly ;)

Revision history for this message
Michael Vogt (mvo) wrote :

Software-center will need a recomends against gvfs-backends for this to work with https locations. That is installed by default on most machines, but missing on e.g. xubuntu (and kubuntu I assume).

Revision history for this message
Michael Vogt (mvo) wrote :

Please let me know about the work it will be to do http for the images. If its too cumbersome I can add a recommends on s-c for the "gvfs-backends" package to ensure its working properly on all derivatives. But given that this is the only place where we need the gio https support it would be nice if it could be avoided.

tags: added: kb-defect sp-1
Changed in software-center-agent:
status: New → In Progress
assignee: nobody → Michael Nelson (michael.nelson)
Revision history for this message
Michael Nelson (michael.nelson) wrote :

The attached branch enables http for all uploaded media url's *except* packages (banners, icons, screeshots). But the fix working is also dependent on removing the redirection in the apache config, as per RT 49574.

Changed in software-center-agent:
status: In Progress → Fix Committed
Revision history for this message
Dave Morley (davmor2) wrote :

This is http on vps but staging will be a better test

Revision history for this message
Dave Morley (davmor2) wrote :

Yeap http on staging too

Changed in software-center-agent:
milestone: none → 11.12
Changed in software-center-agent:
status: Fix Committed → Fix Released
status: Fix Released → Fix Committed
tags: added: client-server
Michael Vogt (mvo)
Changed in software-center (Ubuntu):
status: New → Fix Released
Dave Morley (davmor2)
Changed in software-center-agent:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.