FTBFS on precise, amd64

[Mathieu Trudel-Lapierre]

VLC still fails to build at least on amd64 after fixing up libshout (bug 890634) and other .la file issues:

# source='vlcshell.cpp' object='libvlcplugin_la-vlcshell.lo' libtool=yes
/bin/bash ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../../include -D_FORTIFY_SOURCE=2 -DSYS_LINUX `top_srcdir="../.." top_builddir="../.." ../../vlc-config --cxxflags mozilla` -DDATA_PATH=\"/usr/share/vlc\" -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -c -o libvlcplugin_la-vlcshell.lo `test -f 'vlcshell.cpp' || echo './'`vlcshell.cpp
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../../include -D_FORTIFY_SOURCE=2 -DSYS_LINUX -D_FILE_OFFSET_BITS=64 -D__USE_UNIX98 -D_REENTRANT -D_THREAD_SAFE -DXP_UNIX -DMOZ_X11 -D_FORTIFY_SOURCE=2 -DSYS_LINUX -DXP_UNIX -I/usr/include/firefox-8.0 -O2 -ffast-math -funroll-loops -mtune=athlon64 -fomit-frame-pointer -DDATA_PATH=\"/usr/share/vlc\" -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -c vlcshell.cpp -fPIC -DPIC -o .libs/libvlcplugin_la-vlcshell.o
In file included from vlcshell.cpp:40:0:
vlcshell.h:27:37: error: new declaration 'char* NPP_GetMIMEDescription()'
/usr/include/firefox-8.0/npapi.h:792:13: error: ambiguates old declaration 'const char* NPP_GetMIMEDescription()'
vlcshell.cpp: In function 'char* NPP_GetMIMEDescription()':
vlcshell.cpp:74:37: error: new declaration 'char* NPP_GetMIMEDescription()'
/usr/include/firefox-8.0/npapi.h:792:13: error: ambiguates old declaration 'const char* NPP_GetMIMEDescription()'
make[3]: *** [libvlcplugin_la-vlcshell.lo] Erreur 1
make[3]: quittant le répertoire « /home/mtrudel/Public/build-area/vlc-1.1.12/projects/mozilla »

With the fix from bug 890634 and the attached patch vlc builds properly locally.

[Benjamin Drung (bdrung)]

Does VLC with this patch build with older versions of xulrunner? Upstream has a slightly more complex fix for this build failure [1]. You may want to adopt that.

[1] http://git.videolan.org/?p=npapi-vlc.git;a=commitdiff;h=a9aa594f5101f550e03c31da899c6c1968fb1e00

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "vlc-firefox-npapi-mime.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Launchpad Janitor (janitor)]

This bug was fixed in the package vlc - 1.1.12-2ubuntu1

---------------
vlc (1.1.12-2ubuntu1) precise; urgency=low

  * debian/patches/vlc-firefox-npapi-mime.patch: deal with whether NPP_/NP_
    GetMIMEDescription function returns const or not; patch from upstream git.
    (LP: #890911)
 -- Mathieu Trudel-Lapierre <email address hidden> Tue, 15 Nov 2011 17:53:42 -0500