"Get star catalogue" button not translated on language change

[Bogdan Marinov]

A very long-standing bug. The "Get catalogue X of Y" button in the Configuration window and the rest of the star catalogue text is not re-generated when the language is changed. At the same time, the text used by default in the window's .ui file is included in the .pot file, confusing both users and translators.

[Bogdan Marinov (daggerstab)]

Fix committed as revision 5020 to the trunk branch:
http://bazaar.launchpad.net/~stellarium/stellarium/trunk/revision/5020

May need some additional work: the existing function populating the button label was re-used, but it also loads star catalog data, which may slow down the translation or cause a bug when language is changed during a download. More testing is needed!

[Bogdan Marinov (daggerstab)]

And of course, testing proves me right and the "fix" introduces a new bug.

[Bogdan Marinov (daggerstab)]

A fix for the fix has been committed as revision 5021:
http://bazaar.launchpad.net/~stellarium/stellarium/trunk/revision/5021?start_revid=5021

This time almost everything is handled properly, except for some error warnings that shouldn't be a problem.

In the process of fixing this, another old bug was (re-)discovered:
https://bugs.launchpad.net/stellarium/+bug/890789