valgrind warning from innodb_fake_changes patch
Bug #890404 reported by
Mark Callaghan
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Server moved to https://jira.percona.com/projects/PS |
Fix Released
|
Medium
|
Laurynas Biveinis | ||
5.1 |
Fix Released
|
Medium
|
Laurynas Biveinis | ||
5.5 |
Fix Released
|
Medium
|
Laurynas Biveinis |
Bug Description
The problem occurs because btr_cur_
if (!(flags & BTR_KEEP_SYS_FLAG)) {
I am new to this code and think that adding '& !trx->fake_changes' to the 'if' block above might fix the problem
Related branches
lp:~laurynas-biveinis/percona-server/bug890404-5.1
- Stewart Smith (community): Approve
- Sergei Glushchenko (community): Approve (g2)
-
Diff: 116 lines (+51/-5)3 files modifiedPercona-Server/mysql-test/r/percona_innodb_fake_changes.result (+22/-2)
Percona-Server/mysql-test/t/percona_innodb_fake_changes.test (+28/-2)
Percona-Server/storage/innodb_plugin/btr/btr0cur.c (+1/-1)
lp:~laurynas-biveinis/percona-server/bug890404-5.5
- Sergei Glushchenko (community): Approve (g2)
- Stewart Smith (community): Approve
-
Diff: 286 lines (+1/-105)3 files modifiedPercona-Server/mysql-test/r/percona_innodb_fake_changes.result (+0/-55)
Percona-Server/mysql-test/t/percona_innodb_fake_changes.test (+0/-49)
Percona-Server/storage/innobase/btr/btr0cur.c (+1/-1)
Changed in percona-server: | |
assignee: | nobody → Valentine Gostev (longbow) |
Changed in percona-server: | |
importance: | Undecided → Medium |
Changed in percona-server: | |
assignee: | Valentine Gostev (longbow) → nobody |
To post a comment you must log in.
Testcase after porting this to the facebook patch -->
--source include/ have_innodb_ plugin. inc
--disable_warnings
DROP TABLE IF EXISTS t3;
--enable_warnings
CREATE TABLE t3 (a INT primary key, b text) ENGINE=InnoDB;
INSERT INTO t3 VALUES (1,'');
SET autocommit=1; fake_changes= 1;
SET innodb_
--error ER_ERROR_ DURING_ COMMIT 'b',11000, 'c') where a=1;
UPDATE t3 set b=lpad(