empty css statements crashes linter

[Jeroen T. Vermeulen]

Our lint check crashes on lib/lp/app/javascript/activator/assets/skins/sam/activator-skin.css: it contains an empty CSS class.

This may be a bug in pocketlint as well; I don't know whether a CSS class is allowed to be empty. There may be some trivial workaround.

[Curtis Hovey (sinzui)]

This defect is in pocketlint/contrib/cssccc.py and can be fixed today.

Traceback (most recent call last):
  File "/usr/bin/pocketlint", line 6, in <module>
    sys.exit(main(sys.argv))
  File "/usr/lib/pymodules/python2.7/pocketlint/formatcheck.py", line 617, in main
    return check_sources(sources, reporter)
  File "/usr/lib/pymodules/python2.7/pocketlint/formatcheck.py", line 601, in check_sources
    checker.check()
  File "/usr/lib/pymodules/python2.7/pocketlint/formatcheck.py", line 250, in check
    CSSChecker(self.file_path, self.text, self._reporter).check()
  File "/usr/lib/pymodules/python2.7/pocketlint/formatcheck.py", line 424, in check
    self.check_css_coding_conventions()
  File "/usr/lib/pymodules/python2.7/pocketlint/formatcheck.py", line 449, in check_css_coding_conventions
    CSSCodingConventionChecker(self.text, logger=self.message).check()
  File "/usr/lib/pymodules/python2.7/pocketlint/contrib/cssccc.py", line 294, in check
    rule.check()
  File "/usr/lib/pymodules/python2.7/pocketlint/contrib/cssccc.py", line 128, in check
    self.checkDeclarations()
  File "/usr/lib/pymodules/python2.7/pocketlint/contrib/cssccc.py", line 170, in checkDeclarations
    start_line = self.declarations.getStartLine()
  File "/usr/lib/pymodules/python2.7/pocketlint/contrib/cssccc.py", line 255, in getStartLine
    character = text[index]
IndexError: string index out of range

[Jeroen T. Vermeulen (jtv)]

Thanks Curtis! The hack I used to work around the exception was to add a blank to the "text" string that's being indexed. But you may find that wasteful.

[Curtis Hovey (sinzui)]

An empty selector is legitimate CSS. a crash that prevent the linter from saying that the style is OK is bad.