dispatcher log is obscure in boot_linaro_android_image if failed

[Spring Zhang]

dispatcher run 'adb disconnect ' but it is not logged in log, which causes some trouble to find root cause.

Log:

root@linaro: echo 0>/sys/class/android_usb/android0/enable
cannot create /sys/class/android_usb/android0/enable: directory nonexistent
root@linaro: setprop service.adb.tcp.port 5555
root@linaro: stop adbd
root@linaro: start adbd
root@linaro:
root@linaro: ifconfig eth0
eth0: Cannot assign requested address
root@linaro: [ 22.557981] eth0: Freescale FEC PHY driver [SMSC LAN8710/LAN8720] (mii_bus:phy_addr=1:00, irq=-1)
[ 24.557741] PHY: 1:00 - Link is Up - 100/Full

root@linaro: ifconfig eth0
eth0: ip 10.192.244.14 mask 255.255.255.0 flags [up broadcast running<LAVA_DISPATCHER>2011-11-11 06:13:46 PM ERROR: boot_linaro_android_image failed: The command was not found or was not executable: adb.
Traceback (most recent call last):
  File "/home/spring/linaro/lava/add-mx53-android/lava_dispatcher/actions/boot_control.py", line 36, in run
    client.boot_linaro_android_image()
  File "/home/spring/linaro/lava/add-mx53-android/lava_dispatcher/client.py", line 239, in boot_linaro_android_image
    self.android_adb_disconnect_over_default_nic_ip()
  File "/home/spring/linaro/lava/add-mx53-android/lava_dispatcher/client.py", line 309, in android_adb_disconnect_over_default_nic_ip
    self.android_adb_disconnect(dev_ip)
  File "/home/spring/linaro/lava/add-mx53-android/lava_dispatcher/client.py", line 258, in android_adb_disconnect
    pexpect.run(cmd, timeout=300, logfile=sys.stdout)
  File "/usr/lib/python2.6/dist-packages/pexpect.py", line 221, in run
    child = spawn(command, timeout=timeout, maxread=2000, logfile=logfile, cwd=cwd, env=env)
  File "/usr/lib/python2.6/dist-packages/pexpect.py", line 429, in __init__
    self._spawn (command, args)
  File "/usr/lib/python2.6/dist-packages/pexpect.py", line 516, in _spawn
    raise ExceptionPexpect ('The command was not found or was not executable: %s.' % self.command)
ExceptionPexpect: The command was not found or was not executable: adb.
<LAVA_DISPATCHER>2011-11-11 06:13:46 PM INFO: Action boot_linaro_android_image finished.

[Spring Zhang (qzhang)]

Plan to add more log with adb command

[Yongqin Liu (liuyq0307)]

> root@linaro: ifconfig eth0
> eth0: ip 10.192.244.14 mask 255.255.255.0 flags [up broadcast
> running<LAVA_DISPATCHER>2011-11-11 06:13:46 PM ERROR:

sorry if mistake.
isn't this the failed reason?

> boot_linaro_android_image failed: The command was not found or was not
> executable: adb.
>

Thanks,
Yongqin Liu

[Spring Zhang (qzhang)]

It is, but it cost some time to find out where the issue exists in the code, if we can print some action before we're going to execute some commands. The warning shows there is something wrong in boot_linaro_android_image, but there are deep calls in the function which prevent getting an exact position.

And not just for the error here, we may add other information elsewhere