req_vars is documented as a list of tuples
Bug #888866 reported by
Robert Collins
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Robert Collins | ||
OOPS model |
Fix Released
|
High
|
Robert Collins | ||
Python OOPS Date-dir repository |
Fix Released
|
High
|
Robert Collins | ||
python-oops-tools |
Fix Released
|
High
|
Robert Collins | ||
python-oops-wsgi |
Fix Released
|
High
|
Robert Collins |
Bug Description
It is like this due to serialisation issues in the old rfc822 days. We can if we want switch it to a dict now - like the wsgi dict it regularly wraps.
This needs changes in oops-tools (which consumes them) first, and then in datedir-repo (which needs to serialise and parse correctly, and then in the docs of oops itself.
Related branches
lp:~lifeless/python-oops-tools/bug-888866
- Ian Booth (community): Approve (code)
-
Diff: 69 lines (+30/-10)3 files modifiedsrc/oopstools/NEWS.txt (+3/-0)
src/oopstools/oops/models.py (+18/-10)
src/oopstools/oops/test/test_dboopsloader.py (+9/-0)
lp:~lifeless/python-oops-datedir-repo/bug-888866
- Ian Booth (community): Approve (code)
-
Diff: 211 lines (+61/-29)8 files modified.bzrignore (+1/-0)
.testr.conf (+4/-0)
NEWS (+5/-0)
README (+4/-0)
oops_datedir_repo/serializer_bson.py (+2/-2)
oops_datedir_repo/serializer_rfc822.py (+7/-2)
oops_datedir_repo/tests/test_serializer.py (+5/-5)
oops_datedir_repo/tests/test_serializer_rfc822.py (+33/-20)
lp:~lifeless/launchpad/oops-polish
- William Grant: Approve (code)
-
Diff: 163 lines (+71/-17)4 files modifiedlib/canonical/launchpad/webapp/errorlog.py (+5/-0)
lib/canonical/launchpad/webapp/login.py (+10/-4)
lib/canonical/launchpad/webapp/tests/test_errorlog.py (+16/-0)
lib/canonical/launchpad/webapp/tests/test_login.py (+40/-13)
Changed in python-oops-tools: | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in python-oops-datedir-repo: | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in launchpad: | |
status: | New → Triaged |
Changed in python-oops-wsgi: | |
status: | New → Triaged |
Changed in launchpad: | |
importance: | Undecided → High |
Changed in python-oops-wsgi: | |
importance: | Undecided → High |
Changed in python-oops-tools: | |
assignee: | nobody → Robert Collins (lifeless) |
status: | Triaged → In Progress |
Changed in python-oops-datedir-repo: | |
status: | Triaged → In Progress |
assignee: | nobody → Robert Collins (lifeless) |
Changed in python-oops-datedir-repo: | |
status: | In Progress → Fix Released |
Changed in python-oops: | |
status: | Triaged → In Progress |
Changed in python-oops-tools: | |
status: | In Progress → Fix Committed |
Changed in python-oops: | |
status: | In Progress → Fix Released |
assignee: | nobody → Robert Collins (lifeless) |
Changed in python-oops-wsgi: | |
status: | Triaged → In Progress |
assignee: | nobody → Robert Collins (lifeless) |
Changed in python-oops-wsgi: | |
status: | In Progress → Fix Released |
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Robert Collins (lifeless) |
Changed in launchpad: | |
status: | In Progress → Fix Committed |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Changed in python-oops-tools: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.