Serials: allow non-numeric input for combined issues in alt. serials control view

[Lebbeous Fogle-Weekley]

This is for master, and I think it can be considered a bugfix and backported to 2.1.

    Serials: allow freer input in holding code mini-wizard

    In the Subscription Details interface of the Alternate Serials Control
    View, under the Issuance tab, if you create a new issuance you can
    now enter things like "01/02" in (say) the month field to denote a combined
    January/February issue. All those fields are now free-form, whereas some of
    them used to be numeric only.

    Also, avoid an occasional issue where an error message about
    dijit.form.DateTextBox not being a constructor would appear in the
    JavaScript console. The problem was in a race condition among some
    co-dependent JavaScript files that were all being loaded at the same
    time.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/senator/serials-holding-non-numeric

[Dan Wells (dbw2)]

Hello Lebbeous,

In testing using the "01/02" value, I get the following error:

"A valid holding code cannot be produced with any blank fields."

It looks like we need to also remove the isNaN() check in HoldingCode.js. If you can verify and push, I'll sign off.

Thank you,
Dan

[Lebbeous Fogle-Weekley (lebbeous)]

Dan,

You're right. I've changed that to a triple-equals test against "", and force-pushed a commit to the same branch.

Thanks!

Lebbeous

[Dan Wells (dbw2)]

Tested and committed back through rel_2_0 (I'd consider it a straight bugfix). Thank you, Lebbeous.