update xwax to 1.2

[Owen Williams]

Xwax has released version 1.0, bring that into mixxx so we're up to date. (also need to check for api changes, etc)

[Lily (starlily)]

xwax is now on version 1.2 as of March :)

[RJ Skerry-Ryan (rryan)]

How time flies! :)

[Owen Williams (ywwg)]

Done and tested with Serato and Traktor V1 Vinyl

(lp:mixxx/1.11 commit 3413)

[Owen Williams (ywwg)]

Ah I misread the bug report and put this in the wrong branch -- the API changes are very minor, however (check out diff to vinylcontrolxwax.cpp) -- should I revert the commit?

[RJ Skerry-Ryan (rryan)]

Nope -- I just figured you didn't have time before the 1.11.0 release. Thanks!

Instead of Q_ASSERT'ing in VinylControlXwax is there a way to fail gracefully (i.e. just disable vinyl control or something?). I'm trying to get rid of all the Q_ASSERTs.

[RJ Skerry-Ryan (rryan)]

Also, the Windows build is broken :).
http://builds.mixxx.org/jenkins/job/mixxx-1.11-release-windows/architecture=i386,os=windows/107/console

[RJ Skerry-Ryan (rryan)]

stdbool.h isn't available on Windows and the diff has this in timecoder.h:
-#ifndef _MSC_VER
 #include <stdbool.h>
-#endif

I assume because Windows is not supported? Or maybe this is a patch we put in place on top of xwax.

[Owen Williams (ywwg)]

Good catch, yeah we tweaked the file a bit for windows. I should really make a diff that I can just apply to xwax's source to make this easier.

[Owen Williams (ywwg)]

Fixes applied. The vinyl control code currently doesn't have a failure mode, so I did what we do elsewhere and default to serato side A.

[Owen Williams (ywwg)]

OK the build server finally likes the win32 versions of the files now. I'm going to make a diff so this doesn't happen again

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6095