About Window Re-sizable

Bug #887823 reported by KWhat
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Daniel Schürmann

Bug Description

The about dialog window should not be re-sizable.

Related branches

Revision history for this message
KWhat (alex.barker) wrote :

Not very good with QT but here is a patch ;) I took a look at the docs, there didnt seem to be a disable resize prop or

RJ Skerry-Ryan (rryan)
Changed in mixxx:
assignee: nobody → KWhat (alex.barker)
importance: Undecided → Low
status: New → Confirmed
milestone: none → 1.11.0
milestone: 1.11.0 → 1.10.0
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Why not resize the window if the user tries?
I think the underlying problem is that the content does not resize as well.
I am in favour to allow resize, but also stretch the team box.

Revision history for this message
jus (jus) wrote :

+1
As Daniel said.

Changed in mixxx:
assignee: KWhat (alex.barker) → Daniel Schürmann (daschuer)
status: Confirmed → In Progress
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Here it is:

Note: I had to delete all src/ui_*.h files to make this working. It seems that they where the mess from previous scons scripts.

Revision history for this message
jus (jus) wrote :

Tried your patch Daniel, looks good to me even though the margins between the elements have become fairly wide. I found it just right in the old box, it gave more room to the actual text in the default view.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Thank you jus, I did not notice until yet. It must be happened accidentally ... I will have a look.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
Daniel Schürmann (daschuer) wrote :

OK, this must be an linux <-> Mac OSX issue. On Ubuntu, the patched about box has the same margins then the unpatched version.
The attached patch defines explicit the default margin of 9. Jus, please test it this has any effect

Revision history for this message
jus (jus) wrote :

Sorry to say but with there is no visible effect at all .

Revision history for this message
Daniel Schürmann (daschuer) wrote :

I think this uneleganz must be solved by a Mac user.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6091

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.