The new statistics slider does not update if the window is left open

[Hans Joachim Desserud]

(Split out from bug 536543)
1. Start a new game.
2. Open Statistics->General Statistics.
3. Leave the window open and increase the game speed to 50x and leave it for a while

Expected result:
New options should be added to the slider as time goes, when they make sense.

Actual result:
While the window is open, the slider does not update. However, if you close the window and reopen it, any new options that make sense will have been added.

It was commented on bug 536543 that this was a known issue, and would probably be hard to fix with the current code.

Widelands r6090.

[Joachim Breitner (nomeata)]

Just a remark for later: It should actually be slightly easier now; a call to layout() in the DiscreteSlider class should take care of any rearranging. The only problem left is to communicate the change from the WUI_Plot class to the associated slider. But a simple pointer could work, assuming (or enforcing) that at most one slider is generated for a given Plot instance.

[Joachim Breitner (nomeata)]

Ok, I think I got it, see the related merge request.

[SirVer (sirver)]

r6091

[LAZA (laza74)]

I hope, i understood the bug reporter correct - then this bug is not fixed in bzr6335!

- start game
- open statistics (Warenstatistik)
- play

There are now two possibilities to set the time:
15 min - game

Closing the statistics and reopen it, i got after 50 min those possibilities:
15 min - 30 min - game

Can somebody please confirm?!?

[SirVer (sirver)]

Released in build17-rc1.

[Hans Joachim Desserud (hjd)]

Regarding #4, since the slider was added, it now shows only a few options intially then add more as they become useful. (Compared to the old buttons which always had the same set of buttons always available) As an example, seeing the stats for the latest 8 hours doesn't do much good if your game has only lasted half an hour. On the other hand, once you have played 8 hours, it would be useful to add that as an option, so that happens automatically.

The original bug here was that if you had the statistics window open as time went by, the new options wouldn't be added unless you closed the window and reopened it again. So new options adding themselves over time is expected behaviour, regardless whether the statistics window is open or not.

>Closing the statistics and reopen it, i got after 50 min those possibilities:
>15 min - 30 min - game

So after 50 mins of in-game time, those three options should be available whether or not the statistics window has been open the whole time or not. If this is not the case, please reply/elaborate.