--login does not work in 2.4.2

Bug #887105 reported by Tobias Dussa
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sakura
Fix Released
High
David Gómez
sakura (Debian)
Fix Released
Unknown
sakura (Ubuntu)
Fix Released
Medium
Andrew Starr-Bochicchio

Bug Description

Hi,

I've recently upgraded from 2.3.8 to 2.4.2 (with an update to Oneiric ;-)), and sakura stopped working when called with the "--login" parameter.

A little bit of stracing reveals something that looks like the problem: The shell is not execve()ed correctly any more. In 2.3.8, by comparison,
the shell is spawned with the correct binary and the correct argv[0] parameter for login shells (that is, a dash is prepended to the argv[0] parameter).
This looks like this in an strace:
---
execve("/bin/zsh", ["-/bin/zsh"] ...
---
2.4.2 now tries to spawn my zsh like this:
---
execve("-/bin/zsh", ["-/bin/zsh"] ...
---
which fails because "-/bin/zsh" is no valid binary, of course. Interestingly, sakura then just hangs instead of quitting, so there may be other problems.
But as far as I can see, this behavior is a bug and should be fixed.

Cheers,
Toby.

David Gómez (dabisu)
Changed in sakura:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → David Gómez (dabisu)
David Gómez (dabisu)
Changed in sakura:
status: Confirmed → Fix Committed
Changed in sakura (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Changed in sakura (Debian):
status: Unknown → Confirmed
Revision history for this message
Tobias Dussa (tobias-launchpad-dussa) wrote :

Is there any news on this issue? There is a bugfix upstream, so surely this shouldn't be too hard to ship?!?

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

Thanks for the reminder. I've prepared an upload for Debian containing the fix, and will sync it to Ubuntu once it has been sponsored.

Changed in sakura (Ubuntu):
assignee: nobody → Andrew Starr-Bochicchio (andrewsomething)
status: Triaged → In Progress
Revision history for this message
David Gómez (dabisu) wrote :

Yes, it's upstream, i was holding the release because of another issue, but i haven't done nothing these last days, so i guess i'll make release ASAP with the current upstream code.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sakura - 2.4.2-3

---------------
sakura (2.4.2-3) unstable; urgency=low

  * set DM-Upload-Allowed to yes

 -- Norbert Preining <email address hidden> Wed, 25 Jan 2012 13:17:04 +0900

Changed in sakura (Ubuntu):
status: In Progress → Fix Released
Changed in sakura (Debian):
status: Confirmed → Fix Released
David Gómez (dabisu)
Changed in sakura:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.