[trunk] email_template

[patvad]

i'am testing Openerp 6.1 on runbot.openerp (web-trunk)

i created an email template ( for invoice ) with a button in action bar and i can not use this template.

i get the same wizard that mass mailing and template fields are not used.

The button name is not good. (it is the template name)

[Vishal Parmar(Open ERP) (vpa-openerp)]

Hello Patvad,

I have checked your issue with latest updated code of trunk but it is working normally at my end.

Would you please elaborate more and give video or screenshot so I can understand where you face the problem.

Thanks and waiting for your reply.

[patvad (patrick-vade)]

i retried with a video recording. see attached file.

Plateform ubuntu 11.10

server revision : 3785
web revision : 1418
addons revision : 5537

[Kuldeep Joshi(OpenERP) (kjo-openerp)]

I have checked your issue with latest updated trunk and It work fine in GTK-Client. So as per my knowledge in Web-Clinet context is not pass properly it give following error :-
NameError: name 'active_id' is not defined

So,I will change the assign

[patvad (patrick-vade)]

I have rechecked with trunk addons rev: 5934, server rev:3865 and web rev:1670 and i still have problem with email_template preview and action buttons defined in email_templates.

The preview is ok in GTK but not ok in web interface.
Action does not work in GTK and web interface.

[patvad (patrick-vade)]

mailing is a main feature in CRM and ERP, why this bug is classified "low priority" ?
For my users, a tool without email function is useless.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

Preview works in web client now, after looking into it further there's a twofold issue in the email_template addon code:

* Some values are not kept across reloads in the web client (due to a missing bit of addons code), leading to the templates list not displaying
* The specific template is not automatically selected by the action button

The first issue should be fixed in addons trunk revision <email address hidden>

[Xavier (Open ERP) (xmo-deactivatedaccount)]

As for

> The button name is not good. (it is the template name)

it's actually the action name generated with the button, I fear this is a server issue, clients get their sidebar action lists from the server, including their names, during fields_view_get and here the server only returns the action's name so that is what the clients display.

[Olivier Dony (Odoo) (odo-openerp)]

The remaining issues have just been fixed in the latest version of the 6.1 addons:

- specific template is not selected when opening the composition wizard [1]
- wizard button using template name in the sidebar [2] - btw to fix the name you'll need to delete and re-create the action

[1] rev.6406 rev-id: <email address hidden>
[2] rev.6405 rev-id: <email address hidden>

Thanks for reporting!

[patvad (patrick-vade)]

Hello,

I am retesting email_template with openerp-6.1dev-20120202-020001.tar.gz source.
I am trying to send an email with a report in attachments.
It seems this module in not working completely.
see screen capture attached.

may be i do not use it correctly .

[patvad (patrick-vade)]

Hello,

I continue my tests when i am time.

 I think there is a bug in method "create_action" of class email_template.
'context': "{'mail.compose.message.mode':'mass_mail', 'mail.compose.template_id' : %d}" % (template.id),
'mass_mail' is not good. when i change it by 'mail' for example the report is generated.

in the same class methode generate_email,
 service = netsvc.LocalService(report_service)
            (result, format) = service.create(cr, uid, [res_id], {'model': template.model}, ctx)
           result = base64.b64encode(result)

b64encode must be remove because the attachement is encoded later in another method.

To finish there is a problem with the filename in the mime header. the mails are sent with " at the end of the filename (ex: so007/pdf") this can disturb some mail client software ( ex: orange.fr webmail replace the filename with 'no filename' for the attachment). For this point i did not find the part to modify.

[Jeroen Vet (jeroen-vet)]

Fixes of patvad were quite useful. Thx! Solved the problem of failing to generate the attachment. Suggest these to adopted.

[Amit Parik (amit-parik)]

According to comment#7 and #11 I am assigning to related team.

Thanks!

[Nimesh Contractor(Open ERP) (nco-openerp)]

Hello,

      I have tested this senario in latest trunk.
      I found that recently the sidebar button is removed in addons with rev no : 7362.
      Now there is no problem in attachment in email templete at all,
      Also there is no problem in preview the template.

      This bug is not reproducable any more in letest trunk.
      Rev Nos.
      Addons : 7437
      Server : 4427
      Web : 3062

      So I am setting this bug to invalid.

      Thanks for Reporting!

Thanks,
 NCO.