ykchalresp fails on armel

[Serge Hallyn]

ykchalresp uses a char to store the getopt return value and then compares it to -1 to detect the end of options. However char is usigned by default on arm, so this breaks.

The trivial one-line fix is to turn 'char c' into a signed char.

[Fredrik Thulin (fredrikt)]

Correct fix is to use 'int' since that is the return type of getopt(3).

Fixed in commit a8e3af907 of upstream project.

/Fredrik

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "Patch which fixes the issue for me" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Fredrik Thulin (fredrikt)]

Attached is the patch I committed to the upstream project, that Serge agrees is a better fix.

I'm a novice in handling Launchpad bug reports. Can someone please advice me what I should do now with this report? Should it be kept open until we release a new version of yubikey-personalization?

Thanks

/Fredrik

[Serge Hallyn (serge-hallyn)]

@Fredrik,

I think you can mark it Fix Committed (not Released) assuming a new
release is coming soon, since the fix is committed upstream.

(see https://wiki.ubuntu.com/Bugs/Status for status definitions)

[Fredrik Thulin (fredrikt)]

We plan on releasing 1.6.2 with the fix early next week, so I followed the suggestion and marked it Fix Committed.

/Fredrik

[Charlie_Smotherman (cjsmo)]

1.6.3-1 is the current precise version. Setting to fixed released