Player's role not shown to other players if the player rejoined to the same role in multiplayer setup

[Hans Joachim Desserud]

This is a bit odd one.

Steps to reproduce
1. Start two instances of Widelands. Let's call them A and B.
2. In A, go to multiplayer->local game->host game and select a map.
3. In B, go to multiplayer->local game and join the local game in A (specify host "localhost").
4. Observe that both players have received default roles, and that both A and B display the same information.
5. In B, leave the multiplayer setup by going back.
6. In B, rejoin the same game.
7. Observe that both players have received default roles, and that both A and B display the same information.

Expected result:
In steps 4 and 7, both players should see that A has been assigned the default role of player1 and B the role of player2.

Actual result:
For some reason, if B rejoins to the same role as the player had when disconnecting, the flag under role is not visible to A.

Some other observations:
* The flag is shown for player B, but apparently not other players.
* All information is shown identical in the intialization list (select tribe, HQ, team).
* If player B rejoins to another position (other players have joined or the previous role was filled by someone else), B is assigned a new role and the flag is shown.
* If B clicks on the flag to select another role, the flag is updated also for other players.

[Hans Joachim Desserud (hjd)]

See the attached example. A on the left, B on the right.

[SirVer (sirver)]

Setting to incomplete for bug sweeping.

[Hans Joachim Desserud (hjd)]

--double doesn't exist anymore. Otherwise, still reproducible in r6968.

[SirVer (sirver)]

Setting to incomplete for bug sweeping.

[Hans Joachim Desserud (hjd)]

Also happens in r7249. Should contain enough information for a developer to look into this issue.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1