combination of log_notifier and log.PublishErrorsHandler causes infinite loop

Bug #883293 reported by Nachi Ueno
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Philip Knouff
OpenStack Quality Assurance
Fix Released
High
Philip Knouff

Bug Description

combination of log_notifier and log.PublishErrorsHandler causes infinite loop like this.
log.error() --> PublishErrorsHandler#notifier.api.notify() --> log_notifier.notify() --> log.error()

PublishErrorsHandler should check FLAGS.list_notifier_drivers FLAGS.notification_driver.

Nachi Ueno (nati-ueno)
Changed in nova:
assignee: nobody → Nachi Ueno (nati-ueno)
Changed in openstack-qa:
assignee: nobody → Nachi Ueno (nati-ueno)
status: New → Confirmed
importance: Undecided → High
Thierry Carrez (ttx)
Changed in nova:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Nachi Ueno (nati-ueno) wrote :
tags: added: forward-port-needed
Changed in openstack-qa:
status: Confirmed → In Progress
Jay Pipes (jaypipes)
Changed in openstack-qa:
assignee: Nachi Ueno (nati-ueno) → Jay Pipes (jaypipes)
Revision history for this message
Nachi Ueno (nati-ueno) wrote :

Jay

Sorry!. Donald was already started to forward port this branch. He got 1 review now.
https://review.openstack.org/#change,1639

Changed in nova:
assignee: Nachi Ueno (nati-ueno) → nobody
Donald Ngo (donald-ngo)
Changed in openstack-qa:
assignee: Jay Pipes (jaypipes) → Donald Ngo (donald-ngo)
Changed in nova:
assignee: nobody → Donald Ngo (donald-ngo)
Donald Ngo (donald-ngo)
Changed in nova:
status: Confirmed → In Progress
Revision history for this message
Mark McLoughlin (markmc) wrote :
Revision history for this message
Vish Ishaya (vishvananda) wrote :

listed review was abandoned, someone should take it and update it.

Changed in nova:
assignee: Donald Ngo (donald-ngo) → nobody
Changed in openstack-qa:
assignee: Donald Ngo (donald-ngo) → nobody
Nachi Ueno (nati-ueno)
Changed in nova:
status: In Progress → Confirmed
Changed in openstack-qa:
status: In Progress → Confirmed
Changed in nova:
assignee: nobody → Philip Knouff (philip-knouff)
Changed in openstack-qa:
assignee: nobody → Philip Knouff (philip-knouff)
Changed in nova:
status: Confirmed → In Progress
Changed in openstack-qa:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/4450

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/4450
Committed: http://github.com/openstack/nova/commit/3c63218ae65953273b761433a0cc4cada041253a
Submitter: Jenkins
Branch: master

commit 3c63218ae65953273b761433a0cc4cada041253a
Author: Philip Knouff <email address hidden>
Date: Thu Feb 23 16:08:44 2012 +0000

    Prevent infinite loop in PublishErrorsHandler

    Fixes bug #883293

    Note: this is an update of https://review.openstack.org/#change,1747
    originally author by Donald Ngo

    Change-Id: Ie6ae4f961fb0519df98408baf0a3f8fac0eb6682

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-4
status: Fix Committed → Fix Released
Changed in openstack-qa:
status: In Progress → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.