Tpac: better behavior for staff saved searches

Bug #883111 reported by Lebbeous Fogle-Weekley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Bill Erickson
Nominated for 2.2 by Lebbeous Fogle-Weekley
Nominated for Main by Lebbeous Fogle-Weekley

Bug Description

Just for Evergreen master.

    Tpac: staff saved searches expand/collapse, use right ou context for setting

    1) Display staff saved searches collapsed by default. This makes the facet
    display right underneath it more accessible in the case of long search
    histories.

    2) When checking the org unit setting for the limiting number of
    searches to save, use the user's ws_ou as the context, since this is a
    staff-client feature.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/senator/tpac-saved-searches-collapsible-and-context

Tags: pullrequest
Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Removed pullrequest tag; going to tweak the mechanism to better persist user preference for expanded or collapsed view of saved searches.

tags: removed: pullrequest
Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Added back pullrequest tag after doing what I mentioned in the previous comment (which was just a fancy way of saying I was going to use a cookie).

tags: added: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

Testing working/working/user/senator/physical-loc...

Changed in evergreen:
assignee: nobody → Bill Erickson (erickson-esilibrary)
status: New → In Progress
Revision history for this message
Bill Erickson (berick) wrote :

A quick note on user/senator/physical-loc. The goal is to change the name of the "orig_loc" parameter to be "physical_loc" to better represent the purpose of the parameter. It will (w/ follow up work) be set to the value of the workstation org unit when present.

Merged to master.

Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

As long as this is still open, this branch http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/senator/no-hits-saved-searches targets the very same feature zone, and will be trivial to test and merge.

Revision history for this message
Bill Erickson (berick) wrote :

Testing 2 branches...

user/senator/tpac-saved-searches-collapsible-and-context -- from original comment, updated to avoid manually pulling the context org unit from ws_ou, since that's now the default physical location

user/senator/no-hits-saved-searches -- show saved searches panel on the zero-hits page

Revision history for this message
Bill Erickson (berick) wrote :

Tested and merged to master.

Changed in evergreen:
status: In Progress → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.