[wishlist] qannotate: use only e-mail for defining the color of annotated lines

Bug #878204 reported by Alexander Belchenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
Wishlist
Alexander Belchenko

Bug Description

This is clearly wishlist. I think it will be better for qannotate to use only e-mail of the commit author to define color of annotated lines. The reason why I think so: some of my commits have my name + e-mail, others have only my e-mail. My coworker at some point has decided that English transcription of his ukranian name was incorrect and therefore his name in new commits has slightly changed, but e-mail address is not. As example see attached screenshot.
This could be the very minimal change.

Tags: qannotate

Related branches

Changed in qbzr:
assignee: nobody → Alexander Belchenko (bialix)
status: Confirmed → In Progress
milestone: none → 0.23beta1
status: In Progress → Fix Released
Revision history for this message
IWATA Hidetaka (hid-iwata) wrote :

This fix has a problem.

Author does not always contain e-mail address. (For example, in the branch branched from svn repository)

Now, qannotate crashes on startup with this error if such a author is in the history.

bzr: ERROR: u'xxx' does not seem to contain a reasonable email address

Changed in qbzr:
status: Fix Released → Incomplete
Revision history for this message
Alexander Belchenko (bialix) wrote : Re: [Bug 878204] Re: [wishlist] qannotate: use only e-mail for defining the color of annotated lines

IWATA Hidetaka пишет:
> This fix has a problem.
>
> Author does not always contain e-mail address. (For example, in the
> branch branched from svn repository)
>
> Now, qannotate crashes on startup with this error if such a author is in
> the history.
>
> bzr: ERROR: u'xxx' does not seem to contain a reasonable email address

OK, that's bad. Can you show me the full traceback for the error, please?

--
All the dude wanted was his rug back

Changed in qbzr:
status: Incomplete → In Progress
Revision history for this message
IWATA Hidetaka (hid-iwata) wrote :

No traceback is shown.

$ bzr qannotate NEWS
bzr: ERROR: u'IWATA Hidetaka' does not seem to contain a reasonable email address

Revision history for this message
Alexander Belchenko (bialix) wrote :

IWATA Hidetaka пишет:
> No traceback is shown.
>
> $ bzr qannotate NEWS
> bzr: ERROR: u'IWATA Hidetaka' does not seem to contain a reasonable email address
>
That should be fixed in trunk r.1482

--
All the dude wanted was his rug back

Changed in qbzr:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.