incomplete domain name fails to send e-mail

[Jonathan Riddell]

My computers fqdn was set to gallus.(null) after an oneiric install. This caused a backtrace when trying to send e-mail with feed-pqm

When I fixedit in /etc/hosts to gallus.local the problem stopped occuring.

Traceback (most recent call last):
  File "/usr/bin/feed-pqm", line 257, in <module>
    sys.exit(main(sys.argv))
  File "/usr/bin/feed-pqm", line 243, in main
    if send_mp(launchpad, mp, send_mail=not opts.nomail):
  File "/usr/bin/feed-pqm", line 160, in send_mp
    SMTPConnection(config).send_email(message)
  File "/usr/lib/python2.7/dist-packages/bzrlib/smtp_connection.py", line 165, in send_email
    self._connect()
  File "/usr/lib/python2.7/dist-packages/bzrlib/smtp_connection.py", line 66, in _connect
    self._create_connection()
  File "/usr/lib/python2.7/dist-packages/bzrlib/smtp_connection.py", line 93, in _create_connection
    raise SMTPError("server refused HELO: %d %s" % (code, resp))
bzrlib.errors.SMTPError: SMTP error: server refused HELO: 501 Syntactically invalid HELO argument(s)

[Martin Packman (gz)]

This is tricky because it's basically a configuration error, and while it would be good to add a check before sending an invalid host name, knowing what level to put that is hard. Arguably Python's smtplib would be best place, and I'm not sure what benefit hydrazine could add by catching the bzrlib SMTPError over just letting it propagate.