pt-online-schema-change doesn't like reserved words in column names

[chris erway]

Hi, we love pt-online-schema-change (thanks!) but unfortunately one of our tables has a column with a reserved name in it. Unfortunately, pt-online-schema-change doesn't escape names with backticks, etc, so we can't use the tool for this one really cool online migration we want to do. Just letting you know -- thanks!

[Baron Schwartz (baron-xaprb)]

Can you point out where it fails to backtick-quote the name so we can find it more easily? We generally use a quoter module to do this pretty universally, so it surprises me that we let one slip through like this.

[TR Jordan (terral-jordan)]

Here's a patch that seems to fix it.

(venv)trjordan@trjordan-desktop:~/repos/percona-toolkit$ bzr diff -r109..110
=== modified file 'bin/pt-online-schema-change'
--- bin/pt-online-schema-change 2011-09-01 16:00:38 +0000
+++ bin/pt-online-schema-change 2011-10-13 19:13:08 +0000
@@ -3829,7 +3829,7 @@
    my $old_table = "`$db`.`$tbl`";
    my $new_table = "`$db`.`$tmp_tbl`";
    my $new_values = join(', ', map { "NEW.$_" } @{$args{columns}});
- my $columns = join(', ', @{$args{columns}});
+ my $columns = join(', ', map { "`$_`" } @{$args{columns}});

    my $delete_trigger = "CREATE TRIGGER mk_osc_del AFTER DELETE ON $old_table "
                       . "FOR EACH ROW "
@@ -3928,7 +3928,7 @@
    my ($dbh, $msg, $from_table, $to_table, $chunks) = @args{@required_args};
    my $pr = $args{Progress};
    my $sleep = $args{sleep};
- my $columns = join(', ', @{$args{columns}});
+ my $columns = join(', ', map { "`$_`" } @{$args{columns}});
    my $n_chunks = @$chunks - 1;

    for my $chunkno ( 0..$n_chunks ) {

[Simon J Mudd (sjmudd)]

Just to comment that I'm also affected by this. I'll try the patch and see if it works.

[Baron Schwartz (baron-xaprb)]

We certainly need to fix this. Thanks for the bug report and the up-votes.

[Dan Cech (dan-aussiedan)]

I arrived at the same patch independently, and can confirm that it resolves the problem.

[Daniel Nichter (daniel-nichter)]

This has been tested with both reserved word and spaces, reproduced, and fixed. It will be in the next release, 2.0.4 (or, you can pull pt-online-schema-change directly from the 2.0 branch).

[Baron Schwartz (baron-xaprb)]

Was this released in 2.0.4?

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-279