Merging records does not merge located URIs

[Dan Scott]

* Evergreen master (almost undoubtedly affects previous versions as well though)
* PostgreSQL 9.0.5
* Fedora 15

The setup:

Add two records to the system. Ensure one has a located URI (856 40 $u $y $9). Add both records to a record bucket. Merge the records, choosing the record that does not have the located URI as the lead record.

Expected results:

The lead record should now have the located URI.

Actual results:

The located URI does not get added to the lead record.

Analysis:

The problem is that the XPath used to generate the counter for looping through the possible located URIs returned a number higher than the number of 856 datafields; rather, it returns a number like '7' for a single 856 (representing subfield nodes, whitespace text nodes, etc). For all of the non-datafield nodes, a NULL result is returned; this is then concatenated onto the string, turning the string NULL as well.

Fix:

Adding a COALSCE() to prevent the NULL values from turning the string NULL works around the problem. There may also be a more efficient XPath expression to get an accurate count of 856 datafields, avoiding pointless loops, but working code wins & is appreciated in the field.

Remedy:

I have pushed the branch user/dbs/fix-merge-record-assets into the working repo to address master. This probably needs to be backported all the way through 2.0, however.

[Dan Scott (denials)]

Added rel_2_1 and rel_2_0 variants to the working repo (and force-pushed a minor update to the master branch, to fix references to "action"):
  * user/dbs/fix-merge-record-assets-2_1
  * user/dbs/fix-merge-record-assets-2_0

[Mike Rylander (mrylander)]

Pushed all three branches. Thanks, Dan!