Download, don't display, CSV files in TPac / My Lists

Bug #873004 reported by Lebbeous Fogle-Weekley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

For evergreen master:

    TPac: One prefers to download CSV, not to display it

    For the "Download CSV" operation in the TPac "My Lists" interface,
    provoke the user's browser to download the file, rather than displaying
    the file in a new tab/window.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/senator/bbag-csv-download

Revision history for this message
Dan Scott (denials) wrote :

Appears to work great, except in current master I'm unable to actually move items to the bookbag from the temporary list - the records just disappear. So - I'm holding off on committing this for now.

Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Dan,

Thanks for checking it out, but that's weird about not being able to move items into a bookbag. In two quick tests, I was able to do so without apparent issues. These tests involved being logged in, adding two items to my temporary list in each case, clicking on View Lists, selected the items from the temporary list via their checkboxes, selecting a bookbag to add them to, and clicking go.

Do you get the problem behavior through a different sequence of actions? Any error messages in your apache logs that coincide?

Revision history for this message
Dan Scott (denials) wrote :

There must have been some issue on my local install, on which I had been testing and merging a few other small merge requests earlier in the day (including merge_record_assets & undeleting records, so all sorts of variables thrown into play). I reinstalled a clean master & db schema and was able to create a temporary list, log in, then create a permanent list and transfer entries to that this time around. Will happily commit to master.

Changed in evergreen:
status: New → Fix Committed
Revision history for this message
Dan Scott (denials) wrote :

Committed to master. Thanks Lebbeous!

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.