latest rel_2_1 OpenLibrary added content handler attempts to call a non-existent method

[imperius1]

On a previously working system, the newest iteration of OpenLibrary.pm seems to break book cover images and generates the following error in osrfsys.log:

[2011-10-11 23:41:35] /usr/sbin/apache2 [DEBG:16488:AddedContent.pm:128:] added content handler failed: jacket_small(0895773406) => Can't locate object method "fetch_data_response" via package "OpenILS::WWW::AddedContent::OpenLibrary" at /usr/local/share/perl/5.10.1/OpenILS/WWW/AddedContent/OpenLibrary.pm line 222.

[Dan Scott (denials)]

It looks like I did a bad backport of some of the OpenLibrary code from what was then Subversion trunk around April 27; I find it hard to believe that a system built on any rel_2_1 release since then could have possibly returned cover art. In any case, I've pushed user/dbs/lp872651-fix-openlibrary-ac to the working repo with backports of two other patches from that point in time that make OpenLibrary work with the old data/details APIs (instead of the Read API, which is how master has been working since June). Tested and it seems to return OpenLibrary cover art nicely.

[imperius1 (imperius1)]

Any chance I can get an update on this issue or some explanation how to patch the system?

[Dan Scott (denials)]

Hi imperius1:

The branch is hosted on the git working repository at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=summary - if you're comfortable with git, you could clone that repo, checkout the user/dbs/lp872651-fix-openlibrary-ac branch, and apply the updated file. Or, a bit easier than that for this case, you should be able to:

1. Download the fixed version of the file directly from http://git.evergreen-ils.org/?p=working/Evergreen.git;a=blob_plain;f=Open-ILS/src/perlmods/lib/OpenILS/WWW/AddedContent/OpenLibrary.pm;hb=refs/heads/user/dbs/lp872651-fix-openlibrary-ac

2. Copy it over top of your existing OpenILS/WWW/AddedContent/OpenLibrary.pm module (probably located in /usr/local/share/perl5 or something like that)

3. Restart Apache

4. See successful cover art etc added content.

[imperius1 (imperius1)]

Works like a charm! Thank you so much and I highly recommend this fix be integrated into the 2.1 stable release. Thanks again!

[Lebbeous Fogle-Weekley (lebbeous)]

Tested successfully in a 2.1 environment with Dan's assistance. Signed off and pushed into rel_2_1.

[Lebbeous Fogle-Weekley (lebbeous)]

I saw this message from Jeff Green in my Launchpad mail, and I'm not sure why it's not actually showing up on this LP bug:

> Can we re-open this for 2.2 latest release, the OpenLibrary.pm in http
> ://open-ils.org/downloads/Evergreen-ILS-2.2.1.tar.gz is also an older
> version of the OpenLibrary API

I'm not sure exactly what he means, but master, rel_2_2, and rel_2_3 all have the same eight commits affecting OpenLibrary.pm beyond what the 2.1 series has, so perhaps Jeff could elaborate on what about the new functionality seems to be the problem? If not that, Jeff, can you tell us about the symptoms you're seeing so that Dan or somebody familiar with that code could reproduce?